systemd: More tweaks to Description and Documentation lines

[libvirt PATCH] systemd: More tweaks to Description and Documentation lines

Posted by Andrea Bolognani 5 months, 3 weeks ago

We recently unified all services and sockets, except a couple
were missed. Finish the job.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/remote/virt-guest-shutdown.target | 4 ++--
 tools/libvirt-guests.service.in       | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/remote/virt-guest-shutdown.target b/src/remote/virt-guest-shutdown.target
index 25d4aaa267..34219d00b0 100644
--- a/src/remote/virt-guest-shutdown.target
+++ b/src/remote/virt-guest-shutdown.target
@@ -1,3 +1,3 @@
 [Unit]
-Description=Libvirt guests shutdown
-Documentation=https://libvirt.org
+Description=libvirt guests shutdown target
+Documentation=https://libvirt.org/
diff --git a/tools/libvirt-guests.service.in b/tools/libvirt-guests.service.in
index c547218f2a..b044444298 100644
--- a/tools/libvirt-guests.service.in
+++ b/tools/libvirt-guests.service.in
@@ -1,5 +1,7 @@
 [Unit]
-Description=Suspend/Resume Running libvirt Guests
+Description=libvirt guests suspend/resume service
+Documentation=man:libvirt-guests(8)
+Documentation=https://libvirt.org/
 Requires=virt-guest-shutdown.target
 After=network.target
 After=time-sync.target
@@ -10,8 +12,6 @@ After=virtvboxd.socket
 After=virtvzd.socket
 After=virtxend.socket
 After=virt-guest-shutdown.target
-Documentation=man:libvirt-guests(8)
-Documentation=https://libvirt.org
 
 [Service]
 EnvironmentFile=-@initconfdir@/libvirt-guests
-- 
2.41.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

Re: [libvirt PATCH] systemd: More tweaks to Description and Documentation lines

Posted by Daniel P. Berrangé 5 months, 3 weeks ago

On Mon, Nov 06, 2023 at 07:43:56PM +0100, Andrea Bolognani wrote:
> We recently unified all services and sockets, except a couple
> were missed. Finish the job.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  src/remote/virt-guest-shutdown.target | 4 ++--
>  tools/libvirt-guests.service.in       | 6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org