[libvirt PATCH 00/11] ci: Build RPMs on MinGW

Andrea Bolognani posted 11 patches 5 months, 3 weeks ago
Failed in applying to current master (apply log)
There is a newer version of this series
.gitlab-ci.yml                                |  11 +-
ci/buildenv/fedora-38-cross-mingw32.sh        |   1 +
ci/buildenv/fedora-38-cross-mingw64.sh        |   1 +
ci/buildenv/fedora-rawhide-cross-mingw32.sh   |   1 +
ci/buildenv/fedora-rawhide-cross-mingw64.sh   |   1 +
.../fedora-38-cross-mingw32.Dockerfile        |   1 +
.../fedora-38-cross-mingw64.Dockerfile        |   1 +
.../fedora-rawhide-cross-mingw32.Dockerfile   |   1 +
.../fedora-rawhide-cross-mingw64.Dockerfile   |   1 +
ci/jobs.sh                                    |  19 +-
libvirt.spec.in                               | 470 ++++++++++--------
11 files changed, 296 insertions(+), 212 deletions(-)
[libvirt PATCH 00/11] ci: Build RPMs on MinGW
Posted by Andrea Bolognani 5 months, 3 weeks ago
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1059447352

The openSUSE Leap 15 job failed, but that's caused by an unrelated
packaging issue:

  $ pkg-config --cflags libtirpc
  -I/usr/include/tirpc
  $ rpm -ql libtirpc-devel | grep usr/include
  /usr/include/netconfig.h
  /usr/include/rpc
  /usr/include/rpc/auth.h
  /usr/include/rpc/auth_des.h
  ...
  /usr/include/rpc/types.h
  /usr/include/rpc/xdr.h
  /usr/include/rpcsvc
  /usr/include/rpcsvc/crypt.h
  /usr/include/rpcsvc/crypt.x

The CI updates towards the end depend on the following unmerged
libvirt-ci changes:

  https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/440

Andrea Bolognani (11):
  rpm: Disable expensive tests for MinGW builds
  rpm: Explicitly enable NLS support
  rpm: Rename module-init-tools -> kmod
  rpm: Explain a couple of BuildRequires
  rpm: Add libxml2 BuildRequires for xmllint
  rpm: Shuffle BuildRequires around
  rpm: Split call to mingw_debug_package
  rpm: Introduce with_mingw32/with_mingw64
  rpm: Introduce with_native
  ci: Refresh generated files
  ci: Build RPMs on MinGW

 .gitlab-ci.yml                                |  11 +-
 ci/buildenv/fedora-38-cross-mingw32.sh        |   1 +
 ci/buildenv/fedora-38-cross-mingw64.sh        |   1 +
 ci/buildenv/fedora-rawhide-cross-mingw32.sh   |   1 +
 ci/buildenv/fedora-rawhide-cross-mingw64.sh   |   1 +
 .../fedora-38-cross-mingw32.Dockerfile        |   1 +
 .../fedora-38-cross-mingw64.Dockerfile        |   1 +
 .../fedora-rawhide-cross-mingw32.Dockerfile   |   1 +
 .../fedora-rawhide-cross-mingw64.Dockerfile   |   1 +
 ci/jobs.sh                                    |  19 +-
 libvirt.spec.in                               | 470 ++++++++++--------
 11 files changed, 296 insertions(+), 212 deletions(-)

-- 
2.41.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [libvirt PATCH 00/11] ci: Build RPMs on MinGW
Posted by Daniel P. Berrangé 5 months, 3 weeks ago
On Thu, Nov 02, 2023 at 11:37:22PM +0100, Andrea Bolognani wrote:
> Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1059447352
> 
> The openSUSE Leap 15 job failed, but that's caused by an unrelated
> packaging issue:
> 
>   $ pkg-config --cflags libtirpc
>   -I/usr/include/tirpc
>   $ rpm -ql libtirpc-devel | grep usr/include
>   /usr/include/netconfig.h
>   /usr/include/rpc
>   /usr/include/rpc/auth.h
>   /usr/include/rpc/auth_des.h
>   ...
>   /usr/include/rpc/types.h
>   /usr/include/rpc/xdr.h
>   /usr/include/rpcsvc
>   /usr/include/rpcsvc/crypt.h
>   /usr/include/rpcsvc/crypt.x

That appears to be due to their update to the new version
that was pushed to repos this week. Their changelog says

  * pkg-config: use the correct replacements for libdir/includedir

but clearly that's been screwed up. THeir previous pkg-config
file had

   Cflags: -I/usr/include

The new one has

   Cflags: -I${includedir}/tirpc

From upstream POV  libtirpc always installed into $include/tirpc,
but suse explicitly undo that to put it in the root.

In thier tumbleweed specfile they munged the .pc file to match,
but i guess that got lost in 15.5 branch :-(

  https://build.opensuse.org/package/view_file/openSUSE:Factory/libtirpc/libtirpc.spec?expand=1

If we want to avoid broken CI upstream after the contaniers get rebuilt
this weekend, we'll need to set CFLAGS="-Wno-missing-include-dirs" in
the suse job

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [libvirt PATCH 00/11] ci: Build RPMs on MinGW
Posted by Andrea Bolognani 5 months, 3 weeks ago
On Fri, Nov 03, 2023 at 10:14:55AM +0000, Daniel P. Berrangé wrote:
> On Thu, Nov 02, 2023 at 11:37:22PM +0100, Andrea Bolognani wrote:
> > The openSUSE Leap 15 job failed, but that's caused by an unrelated
> > packaging issue:
> >
> >   $ pkg-config --cflags libtirpc
> >   -I/usr/include/tirpc
> >   $ rpm -ql libtirpc-devel | grep usr/include
> >   /usr/include/netconfig.h
> >   /usr/include/rpc
> >   /usr/include/rpc/auth.h
> >   /usr/include/rpc/auth_des.h
> >   ...
> >   /usr/include/rpc/types.h
> >   /usr/include/rpc/xdr.h
> >   /usr/include/rpcsvc
> >   /usr/include/rpcsvc/crypt.h
> >   /usr/include/rpcsvc/crypt.x
>
> That appears to be due to their update to the new version
> that was pushed to repos this week. Their changelog says
>
>   * pkg-config: use the correct replacements for libdir/includedir
>
> but clearly that's been screwed up. THeir previous pkg-config
> file had
>
>    Cflags: -I/usr/include
>
> The new one has
>
>    Cflags: -I${includedir}/tirpc
>
> From upstream POV  libtirpc always installed into $include/tirpc,
> but suse explicitly undo that to put it in the root.
>
> In thier tumbleweed specfile they munged the .pc file to match,
> but i guess that got lost in 15.5 branch :-(
>
>   https://build.opensuse.org/package/view_file/openSUSE:Factory/libtirpc/libtirpc.spec?expand=1
>
> If we want to avoid broken CI upstream after the contaniers get rebuilt
> this weekend, we'll need to set CFLAGS="-Wno-missing-include-dirs" in
> the suse job

We also need to make SUSE aware of the issue so they can fix it.

Do you mind taking care of this? I'm trying to wrap something else up
and I'd rather not get further sidetracked if I can help it :)

-- 
Andrea Bolognani / Red Hat / Virtualization
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org