[v4] Migration deprecated parts

[PATCH v4 01/10] migration: Improve json and formatting

Posted by Juan Quintela 2 years, 3 months ago

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 qapi/migration.json | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/qapi/migration.json b/qapi/migration.json
index d7dfaa5db9..6865fea3c5 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -73,7 +73,7 @@
 { 'struct': 'MigrationStats',
   'data': {'transferred': 'int', 'remaining': 'int', 'total': 'int' ,
            'duplicate': 'int',
-           'skipped': { 'type': 'int', 'features': ['deprecated'] },
+           'skipped': { 'type': 'int', 'features': [ 'deprecated' ] },
            'normal': 'int',
            'normal-bytes': 'int', 'dirty-pages-rate': 'int',
            'mbps': 'number', 'dirty-sync-count': 'int',
@@ -440,10 +440,9 @@
 #     compress and xbzrle are both on, compress only takes effect in
 #     the ram bulk stage, after that, it will be disabled and only
 #     xbzrle takes effect, this can help to minimize migration
-#     traffic.  The feature is disabled by default.  (since 2.4 )
+#     traffic.  The feature is disabled by default.  (since 2.4)
 #
-# @events: generate events for each migration state change (since 2.4
-#     )
+# @events: generate events for each migration state change (since 2.4)
 #
 # @auto-converge: If enabled, QEMU will automatically throttle down
 #     the guest to speed up convergence of RAM migration.  (since 1.6)
-- 
2.41.0

Re: [PATCH v4 01/10] migration: Improve json and formatting

Posted by Markus Armbruster 2 years, 3 months ago

Juan Quintela <quintela@redhat.com> writes:

> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  qapi/migration.json | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index d7dfaa5db9..6865fea3c5 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -73,7 +73,7 @@
>  { 'struct': 'MigrationStats',
>    'data': {'transferred': 'int', 'remaining': 'int', 'total': 'int' ,
>             'duplicate': 'int',
> -           'skipped': { 'type': 'int', 'features': ['deprecated'] },
> +           'skipped': { 'type': 'int', 'features': [ 'deprecated' ] },
>             'normal': 'int',
>             'normal-bytes': 'int', 'dirty-pages-rate': 'int',
>             'mbps': 'number', 'dirty-sync-count': 'int',
> @@ -440,10 +440,9 @@
>  #     compress and xbzrle are both on, compress only takes effect in
>  #     the ram bulk stage, after that, it will be disabled and only
>  #     xbzrle takes effect, this can help to minimize migration
> -#     traffic.  The feature is disabled by default.  (since 2.4 )
> +#     traffic.  The feature is disabled by default.  (since 2.4)
>  #
> -# @events: generate events for each migration state change (since 2.4
> -#     )
> +# @events: generate events for each migration state change (since 2.4)
>  #
>  # @auto-converge: If enabled, QEMU will automatically throttle down
>  #     the guest to speed up convergence of RAM migration.  (since 1.6)

Reviewed-by: Markus Armbruster <armbru@redhat.com>