Andrea Bolognani (6):
  meson: Do less when not building from git
  meson: Move all handling of test options together
  meson: Handle -Dtests=enabled with Clang
  meson: Make -Dexpensive_tests depend on -Dtests
  meson: Disable all tests when tests are disabled
  meson: Rename build_tests -> tests_enabled

 build-aux/meson.build  |  99 ++++++++++----------
 meson.build            |  75 +++++++++------
 meson_options.txt      |   2 +-
 src/access/meson.build |  16 ++--
 src/meson.build        | 204 +++++++++++++++++++++--------------------
 5 files changed, 207 insertions(+), 189 deletions(-)

-- 
2.41.0

On 10/3/23 16:56, Andrea Bolognani wrote:
> 
> 
> Andrea Bolognani (6):
>   meson: Do less when not building from git
>   meson: Move all handling of test options together
>   meson: Handle -Dtests=enabled with Clang
>   meson: Make -Dexpensive_tests depend on -Dtests
>   meson: Disable all tests when tests are disabled
>   meson: Rename build_tests -> tests_enabled
> 
>  build-aux/meson.build  |  99 ++++++++++----------
>  meson.build            |  75 +++++++++------
>  meson_options.txt      |   2 +-
>  src/access/meson.build |  16 ++--
>  src/meson.build        | 204 +++++++++++++++++++++--------------------
>  5 files changed, 207 insertions(+), 189 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

On Wed, Oct 25, 2023 at 09:41:40AM +0200, Michal Prívozník wrote:
> On 10/3/23 16:56, Andrea Bolognani wrote:
> > Andrea Bolognani (6):
> >   meson: Do less when not building from git
> >   meson: Move all handling of test options together
> >   meson: Handle -Dtests=enabled with Clang
> >   meson: Make -Dexpensive_tests depend on -Dtests
> >   meson: Disable all tests when tests are disabled
> >   meson: Rename build_tests -> tests_enabled
>
> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Thanks a lot for the review!

Unfortunately I have realized that this, merged as-is, would break
things quite badly on macOS and consequently result in every single
pipeline failing. Wouldn't want that :)

Luckily the fix is not complicated and doesn't invalidate most of the
series either. v2 here:

  https://listman.redhat.com/archives/libvir-list/2023-October/242876.html

-- 
Andrea Bolognani / Red Hat / Virtualization

On Tue, Oct 03, 2023 at 04:56:31PM +0200, Andrea Bolognani wrote:
> Andrea Bolognani (6):
>   meson: Do less when not building from git
>   meson: Move all handling of test options together
>   meson: Handle -Dtests=enabled with Clang
>   meson: Make -Dexpensive_tests depend on -Dtests
>   meson: Disable all tests when tests are disabled
>   meson: Rename build_tests -> tests_enabled
>
>  build-aux/meson.build  |  99 ++++++++++----------
>  meson.build            |  75 +++++++++------
>  meson_options.txt      |   2 +-
>  src/access/meson.build |  16 ++--
>  src/meson.build        | 204 +++++++++++++++++++++--------------------
>  5 files changed, 207 insertions(+), 189 deletions(-)

Ping.

This no longer applies cleanly after 7cbd8c423057 but the conflict is
easy enough to handle, so I don't think it's worth posting v2 because
of it.

-- 
Andrea Bolognani / Red Hat / Virtualization