[libvirt PATCH 05/42] systemd: Set @name@ for virtlogd/virtlockd

Andrea Bolognani posted 42 patches 2 years, 4 months ago
There is a newer version of this series
[libvirt PATCH 05/42] systemd: Set @name@ for virtlogd/virtlockd
Posted by Andrea Bolognani 2 years, 4 months ago
The information is not used anywhere right now, but the
documentation for virt_daemon_units claims it's mandatory.

More importantly, we're going to start actually using it later
on.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/locking/meson.build | 2 +-
 src/logging/meson.build | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/locking/meson.build b/src/locking/meson.build
index 57764b0da6..b7ba342171 100644
--- a/src/locking/meson.build
+++ b/src/locking/meson.build
@@ -144,7 +144,7 @@ if conf.has('WITH_LIBVIRTD')
   virt_daemon_units += {
     'service': 'virtlockd',
     'service_in': files('virtlockd.service.in'),
-    'name': '',
+    'name': 'Libvirt locking',
     'sockprefix': '',
     'sockets': [ 'main', 'admin' ],
     'socket_in': files('virtlockd.socket.in'),
diff --git a/src/logging/meson.build b/src/logging/meson.build
index fa6af50fa6..aa8affb52c 100644
--- a/src/logging/meson.build
+++ b/src/logging/meson.build
@@ -91,7 +91,7 @@ if conf.has('WITH_LIBVIRTD')
   virt_daemon_units += {
     'service': 'virtlogd',
     'service_in': files('virtlogd.service.in'),
-    'name': '',
+    'name': 'Libvirt logging',
     'sockprefix': '',
     'sockets': [ 'main', 'admin' ],
     'socket_in': files('virtlogd.socket.in'),
-- 
2.41.0
Re: [libvirt PATCH 05/42] systemd: Set @name@ for virtlogd/virtlockd
Posted by Daniel P. Berrangé 2 years, 4 months ago
On Mon, Sep 25, 2023 at 08:58:03PM +0200, Andrea Bolognani wrote:
> The information is not used anywhere right now, but the
> documentation for virt_daemon_units claims it's mandatory.
> 
> More importantly, we're going to start actually using it later
> on.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  src/locking/meson.build | 2 +-
>  src/logging/meson.build | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|