[libvirt PATCH 04/42] systemd: Set Type=notify for virtlogd/virtlockd

Andrea Bolognani posted 42 patches 2 years, 4 months ago
There is a newer version of this series
[libvirt PATCH 04/42] systemd: Set Type=notify for virtlogd/virtlockd
Posted by Andrea Bolognani 2 years, 4 months ago
This tells systemd that the services in question support the
native socket activation protocol.

virtlogd and virtlockd, just like all the other daemons, implement
the necessary handshake.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/locking/virtlockd.service.in | 1 +
 src/logging/virtlogd.service.in  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/src/locking/virtlockd.service.in b/src/locking/virtlockd.service.in
index f12c3040e9..9e91fa3261 100644
--- a/src/locking/virtlockd.service.in
+++ b/src/locking/virtlockd.service.in
@@ -7,6 +7,7 @@ Documentation=man:virtlockd(8)
 Documentation=https://libvirt.org
 
 [Service]
+Type=notify
 Environment=VIRTLOCKD_ARGS=
 EnvironmentFile=-@initconfdir@/virtlockd
 ExecStart=@sbindir@/virtlockd $VIRTLOCKD_ARGS
diff --git a/src/logging/virtlogd.service.in b/src/logging/virtlogd.service.in
index e665e8a02e..97c942ffb0 100644
--- a/src/logging/virtlogd.service.in
+++ b/src/logging/virtlogd.service.in
@@ -7,6 +7,7 @@ Documentation=man:virtlogd(8)
 Documentation=https://libvirt.org
 
 [Service]
+Type=notify
 Environment=VIRTLOGD_ARGS=
 EnvironmentFile=-@initconfdir@/virtlogd
 ExecStart=@sbindir@/virtlogd $VIRTLOGD_ARGS
-- 
2.41.0
Re: [libvirt PATCH 04/42] systemd: Set Type=notify for virtlogd/virtlockd
Posted by Daniel P. Berrangé 2 years, 4 months ago
On Mon, Sep 25, 2023 at 08:58:02PM +0200, Andrea Bolognani wrote:
> This tells systemd that the services in question support the
> native socket activation protocol.
> 
> virtlogd and virtlockd, just like all the other daemons, implement
> the necessary handshake.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  src/locking/virtlockd.service.in | 1 +
>  src/logging/virtlogd.service.in  | 1 +
>  2 files changed, 2 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|