[v1] systemd: Improve units for services and sockets

[libvirt PATCH 02/42] systemd: Add missing WantedBy for virtlogd/virtlockd

Posted by Andrea Bolognani 2 years, 4 months ago

This annotation being missing resulted in virtlogd and virtlockd
being marked as "indirect" services, i.e. services that cannot
be started directly but have to be socket activated instead.

While this is our preferred configuration, we shouldn't prevent
the admin to start them at boot if they want to.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/locking/virtlockd.service.in | 1 +
 src/logging/virtlogd.service.in  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/src/locking/virtlockd.service.in b/src/locking/virtlockd.service.in
index 18873f86a6..f12c3040e9 100644
--- a/src/locking/virtlockd.service.in
+++ b/src/locking/virtlockd.service.in
@@ -21,5 +21,6 @@ OOMScoreAdjust=-900
 LimitNOFILE=1024:524288
 
 [Install]
+WantedBy=multi-user.target
 Also=virtlockd.socket
 Also=virtlockd-admin.socket
diff --git a/src/logging/virtlogd.service.in b/src/logging/virtlogd.service.in
index 14a991f348..e665e8a02e 100644
--- a/src/logging/virtlogd.service.in
+++ b/src/logging/virtlogd.service.in
@@ -21,5 +21,6 @@ OOMScoreAdjust=-900
 LimitNOFILE=1024:524288
 
 [Install]
+WantedBy=multi-user.target
 Also=virtlogd.socket
 Also=virtlogd-admin.socket
-- 
2.41.0

Re: [libvirt PATCH 02/42] systemd: Add missing WantedBy for virtlogd/virtlockd

Posted by Daniel P. Berrangé 2 years, 4 months ago

On Mon, Sep 25, 2023 at 08:58:00PM +0200, Andrea Bolognani wrote:
> This annotation being missing resulted in virtlogd and virtlockd
> being marked as "indirect" services, i.e. services that cannot
> be started directly but have to be socket activated instead.
> 
> While this is our preferred configuration, we shouldn't prevent
> the admin to start them at boot if they want to.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  src/locking/virtlockd.service.in | 1 +
>  src/logging/virtlogd.service.in  | 1 +
>  2 files changed, 2 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|