[libvirt PATCH 01/42] systemd: Add missing Also for admin socket

Andrea Bolognani posted 42 patches 2 years, 4 months ago
There is a newer version of this series
[libvirt PATCH 01/42] systemd: Add missing Also for admin socket
Posted by Andrea Bolognani 2 years, 4 months ago
When libvirtd, virtlog and virtlockd are enabled, we want their
admin sockets to be enabled as well.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/locking/virtlockd.service.in | 1 +
 src/logging/virtlogd.service.in  | 1 +
 src/remote/libvirtd.service.in   | 1 +
 3 files changed, 3 insertions(+)

diff --git a/src/locking/virtlockd.service.in b/src/locking/virtlockd.service.in
index dd0bbab083..18873f86a6 100644
--- a/src/locking/virtlockd.service.in
+++ b/src/locking/virtlockd.service.in
@@ -22,3 +22,4 @@ LimitNOFILE=1024:524288
 
 [Install]
 Also=virtlockd.socket
+Also=virtlockd-admin.socket
diff --git a/src/logging/virtlogd.service.in b/src/logging/virtlogd.service.in
index 8e245ddb43..14a991f348 100644
--- a/src/logging/virtlogd.service.in
+++ b/src/logging/virtlogd.service.in
@@ -22,3 +22,4 @@ LimitNOFILE=1024:524288
 
 [Install]
 Also=virtlogd.socket
+Also=virtlogd-admin.socket
diff --git a/src/remote/libvirtd.service.in b/src/remote/libvirtd.service.in
index 84f1613adc..8839c00a15 100644
--- a/src/remote/libvirtd.service.in
+++ b/src/remote/libvirtd.service.in
@@ -50,3 +50,4 @@ Also=virtlockd.socket
 Also=virtlogd.socket
 Also=libvirtd.socket
 Also=libvirtd-ro.socket
+Also=libvirtd-admin.socket
-- 
2.41.0
Re: [libvirt PATCH 01/42] systemd: Add missing Also for admin socket
Posted by Daniel P. Berrangé 2 years, 4 months ago
On Mon, Sep 25, 2023 at 08:57:59PM +0200, Andrea Bolognani wrote:
> When libvirtd, virtlog and virtlockd are enabled, we want their
> admin sockets to be enabled as well.

s/enabled/enabled for socket activation/

because these admin sockets were enabled automatically when the
service eventually starts already.

> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  src/locking/virtlockd.service.in | 1 +
>  src/logging/virtlogd.service.in  | 1 +
>  src/remote/libvirtd.service.in   | 1 +
>  3 files changed, 3 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

> 
> diff --git a/src/locking/virtlockd.service.in b/src/locking/virtlockd.service.in
> index dd0bbab083..18873f86a6 100644
> --- a/src/locking/virtlockd.service.in
> +++ b/src/locking/virtlockd.service.in
> @@ -22,3 +22,4 @@ LimitNOFILE=1024:524288
>  
>  [Install]
>  Also=virtlockd.socket
> +Also=virtlockd-admin.socket
> diff --git a/src/logging/virtlogd.service.in b/src/logging/virtlogd.service.in
> index 8e245ddb43..14a991f348 100644
> --- a/src/logging/virtlogd.service.in
> +++ b/src/logging/virtlogd.service.in
> @@ -22,3 +22,4 @@ LimitNOFILE=1024:524288
>  
>  [Install]
>  Also=virtlogd.socket
> +Also=virtlogd-admin.socket
> diff --git a/src/remote/libvirtd.service.in b/src/remote/libvirtd.service.in
> index 84f1613adc..8839c00a15 100644
> --- a/src/remote/libvirtd.service.in
> +++ b/src/remote/libvirtd.service.in
> @@ -50,3 +50,4 @@ Also=virtlockd.socket
>  Also=virtlogd.socket
>  Also=libvirtd.socket
>  Also=libvirtd-ro.socket
> +Also=libvirtd-admin.socket
> -- 
> 2.41.0
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|