Adding the value 'optional' to attribute 'enabled' on the element
async-teardown to provide the optional use of the feature if it is
provided by QEMU.

Boris Fiuczynski (5):
  schemas: Add virYesNoOptional
  util: Add virQuadstateOption and helpers
  virxml: Add virXMLPropQuadstateOption
  conf: Add 'optional' to feature async-teardown
  conf: Ensure migratability if enabled is 'optional'

 docs/formatdomain.rst                         |  7 +--
 src/conf/domain_conf.c                        | 22 +++++----
 src/conf/schemas/basictypes.rng               |  8 ++++
 src/conf/schemas/domaincommon.rng             |  2 +-
 src/libvirt_private.syms                      |  1 +
 src/qemu/qemu_command.c                       |  6 ++-
 src/qemu/qemu_process.c                       | 18 ++++++++
 src/qemu/qemu_validate.c                      |  2 +-
 src/util/virenum.c                            | 46 +++++++++++++++++++
 src/util/virenum.h                            | 15 ++++++
 src/util/virxml.c                             | 28 +++++++++++
 src/util/virxml.h                             |  7 +++
 ...0-async-teardown-optional.s390x-6.0.0.args | 35 ++++++++++++++
 ...-async-teardown-optional.s390x-latest.args | 36 +++++++++++++++
 .../s390-async-teardown-optional.xml          | 24 ++++++++++
 tests/qemuxml2argvtest.c                      |  2 +
 16 files changed, 243 insertions(+), 16 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/s390-async-teardown-optional.s390x-6.0.0.args
 create mode 100644 tests/qemuxml2argvdata/s390-async-teardown-optional.s390x-latest.args
 create mode 100644 tests/qemuxml2argvdata/s390-async-teardown-optional.xml

-- 
2.41.0

On Wed, Aug 09, 2023 at 10:49:42AM +0200, Boris Fiuczynski wrote:
> Adding the value 'optional' to attribute 'enabled' on the element
> async-teardown to provide the optional use of the feature if it is
> provided by QEMU.

This is not something we would typically do. IIUC, this is already
exposed in the domain capabilities XML, so mgmt apps can query
whether the feature is supported or not. They should already be
doing this as they can't assume libvirt itself supports this
feature


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|