It's possible to configure a system such that libvirt-guests connects
to the legacy /run/libvirt/libvirt-sock when running modular daemons,
in which case it connects to virtproxyd. If virtproxyd is stopped before
libvirt-guests, the latter will fail to connect and no running guests
will be stopped/suspended. Likewise on startup, virtproxyd must be
availabel before libvirt-guests. Ensure these conditions are met by
adding an 'After=virtproxyd.socket' ordering dependency to libvirt-guests.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
---
 tools/libvirt-guests.service.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/libvirt-guests.service.in b/tools/libvirt-guests.service.in
index c547218f2a..29607bbd66 100644
--- a/tools/libvirt-guests.service.in
+++ b/tools/libvirt-guests.service.in
@@ -9,6 +9,7 @@ After=virtlxcd.socket
 After=virtvboxd.socket
 After=virtvzd.socket
 After=virtxend.socket
+After=virtproxyd.socket
 After=virt-guest-shutdown.target
 Documentation=man:libvirt-guests(8)
 Documentation=https://libvirt.org
-- 
2.41.0

On 8/1/23 01:06, Jim Fehlig wrote:
> It's possible to configure a system such that libvirt-guests connects
> to the legacy /run/libvirt/libvirt-sock when running modular daemons,
> in which case it connects to virtproxyd. If virtproxyd is stopped before
> libvirt-guests, the latter will fail to connect and no running guests
> will be stopped/suspended. Likewise on startup, virtproxyd must be
> availabel before libvirt-guests. Ensure these conditions are met by

nit: available

> adding an 'After=virtproxyd.socket' ordering dependency to libvirt-guests.
> 
> Signed-off-by: Jim Fehlig <jfehlig@suse.com>

lgtm but don't know enough to add a rb tag.

Ciao,

C

> ---
>  tools/libvirt-guests.service.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/libvirt-guests.service.in b/tools/libvirt-guests.service.in
> index c547218f2a..29607bbd66 100644
> --- a/tools/libvirt-guests.service.in
> +++ b/tools/libvirt-guests.service.in
> @@ -9,6 +9,7 @@ After=virtlxcd.socket
>  After=virtvboxd.socket
>  After=virtvzd.socket
>  After=virtxend.socket
> +After=virtproxyd.socket
>  After=virt-guest-shutdown.target
>  Documentation=man:libvirt-guests(8)
>  Documentation=https://libvirt.org