docs: formatdomain: Mention the QEMU requirement for discard_no_unref

[PATCH] docs: formatdomain: Mention the QEMU requirement for discard_no_unref

Posted by Han Han 9 months, 2 weeks ago

Signed-off-by: Han Han <hhan@redhat.com>
---
 docs/formatdomain.rst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index 973de8dd4f..cd9cb02bf8 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -3296,7 +3296,8 @@ paravirtualized driver is specified via the ``disk`` element.
       image. When enabled, a discard request from within the guest will mark the
       qcow2 cluster as zero, but will keep the reference/offset of that cluster.
       But it will still pass the discard further to the lower layer.
-      This will resolve fragmentation within the qcow2 image. :since:`Since 9.5.0`
+      This will resolve fragmentation within the qcow2 image. :since:`Since 9.5.0
+      (QEMU 8.1)`
 
       In the majority of cases the default configuration used by the hypervisor
       is sufficient so modifying this setting should not be necessary. For
-- 
2.41.0

Re: [PATCH] docs: formatdomain: Mention the QEMU requirement for discard_no_unref

Posted by Martin Kletzander 9 months, 2 weeks ago

On Wed, Jul 26, 2023 at 11:11:39AM +0800, Han Han wrote:
>Signed-off-by: Han Han <hhan@redhat.com>
>---
> docs/formatdomain.rst | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
>index 973de8dd4f..cd9cb02bf8 100644
>--- a/docs/formatdomain.rst
>+++ b/docs/formatdomain.rst
>@@ -3296,7 +3296,8 @@ paravirtualized driver is specified via the ``disk`` element.
>       image. When enabled, a discard request from within the guest will mark the
>       qcow2 cluster as zero, but will keep the reference/offset of that cluster.
>       But it will still pass the discard further to the lower layer.
>-      This will resolve fragmentation within the qcow2 image. :since:`Since 9.5.0`
>+      This will resolve fragmentation within the qcow2 image. :since:`Since 9.5.0
>+      (QEMU 8.1)`
>

This is usually stylised as :since:`Since 9.5.0 and QEMU 8.1.0`.  I'll fix that
before pushing.

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

>       In the majority of cases the default configuration used by the hypervisor
>       is sufficient so modifying this setting should not be necessary. For
>-- 
>2.41.0
>

Re: [PATCH] docs: formatdomain: Mention the QEMU requirement for discard_no_unref

Posted by Martin Kletzander 9 months, 2 weeks ago

On Wed, Jul 26, 2023 at 10:06:32AM +0200, Martin Kletzander wrote:
>On Wed, Jul 26, 2023 at 11:11:39AM +0800, Han Han wrote:
>>Signed-off-by: Han Han <hhan@redhat.com>
>>---
>> docs/formatdomain.rst | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>>diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
>>index 973de8dd4f..cd9cb02bf8 100644
>>--- a/docs/formatdomain.rst
>>+++ b/docs/formatdomain.rst
>>@@ -3296,7 +3296,8 @@ paravirtualized driver is specified via the ``disk`` element.
>>       image. When enabled, a discard request from within the guest will mark the
>>       qcow2 cluster as zero, but will keep the reference/offset of that cluster.
>>       But it will still pass the discard further to the lower layer.
>>-      This will resolve fragmentation within the qcow2 image. :since:`Since 9.5.0`
>>+      This will resolve frag37mentation within the qcow2 image. :since:`Since 9.5.0
>>+      (QEMU 8.1)`
>>
>
>This is usually stylised as :since:`Since 9.5.0 and QEMU 8.1.0`.  I'll fix that
>before pushing.
>

Nope, I was wrong, your way is more common.  I'm looking too much into
it I guess.  Sorry, pushed now.

>Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
>
>>       In the majority of cases the default configuration used by the hypervisor
>>       is sufficient so modifying this setting should not be necessary. For
>>--
>>2.41.0
>>