Revert "meson: attr_dep switch to dependency()"

[PATCH] Revert "meson: attr_dep switch to dependency()"

Jim Fehlig posted 1 patch 10 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20230706174933.19749-1-jfehlig@suse.com

meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH] Revert "meson: attr_dep switch to dependency()"

Posted by Jim Fehlig 10 months ago

openSUSE Leap 15.{4,5} are supported under libvirt's distro support
statement, but they only contain attr version 2.4.47.

Reverts: dffeef89efc2ed1668cb485d6c3e67ef27b824e8
Signed-off-by: Jim Fehlig <jfehlig@suse.com>
---
 meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 958c1a26a0..5fce470c6b 100644
--- a/meson.build
+++ b/meson.build
@@ -901,7 +901,8 @@ if not get_option('apparmor_profiles').disabled()
   endif
 endif
 
-attr_dep = dependency('libattr', required: get_option('attr'))
+# FIXME rewrite to use dependency() once we can use 2.4.48
+attr_dep = cc.find_library('attr', required: get_option('attr'))
 if attr_dep.found()
   conf.set('WITH_LIBATTR', 1)
 endif
-- 
2.41.0

Re: [PATCH] Revert "meson: attr_dep switch to dependency()"

Posted by Andrea Bolognani 10 months ago

On Thu, Jul 06, 2023 at 11:49:18AM -0600, Jim Fehlig wrote:
> openSUSE Leap 15.{4,5} are supported under libvirt's distro support
> statement, but they only contain attr version 2.4.47.
>
> Reverts: dffeef89efc2ed1668cb485d6c3e67ef27b824e8
> Signed-off-by: Jim Fehlig <jfehlig@suse.com>
> ---
>  meson.build | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization