virDomainMigrate3Params: Add missing params

[PATCH python] virDomainMigrate3Params: Add missing params

Posted by Han Han 10 months, 4 weeks ago

Add these missing migrate params:
- VIR_MIGRATE_PARAM_DISKS_URI, since libvirt v6.8.0(49186372db)
- VIR_MIGRATE_PARAM_TLS_DESTINATION, since libvirt v6.0.0(1b8af37213e)
- VIR_MIGRATE_PARAM_COMPRESSION_ZLIB_LEVEL and VIR_MIGRATE_PARAM_COMPRESSION_ZSTD_LEVEL,
since libvirt v9.4.0(150ae3e62b9)

Signed-off-by: Han Han <hhan@redhat.com>
---
 libvirt-override.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/libvirt-override.c b/libvirt-override.c
index 0c198cb..8a86174 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -8154,6 +8154,18 @@ static virPyTypedParamsHint virPyDomainMigrate3Params[] = {
 # ifdef VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS
     { VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS, VIR_TYPED_PARAM_INT },
 # endif
+# ifdef VIR_MIGRATE_PARAM_DISKS_URI
+    { VIR_MIGRATE_PARAM_DISKS_URI, VIR_TYPED_PARAM_STRING },
+#endif
+#ifdef VIR_MIGRATE_PARAM_TLS_DESTINATION
+    { VIR_MIGRATE_PARAM_TLS_DESTINATION, VIR_TYPED_PARAM_STRING },
+#endif
+#ifdef VIR_MIGRATE_PARAM_COMPRESSION_ZLIB_LEVEL
+    { VIR_MIGRATE_PARAM_COMPRESSION_ZLIB_LEVEL, VIR_TYPED_PARAM_INT },
+#endif
+#ifdef VIR_MIGRATE_PARAM_COMPRESSION_ZSTD_LEVEL
+    { VIR_MIGRATE_PARAM_COMPRESSION_ZSTD_LEVEL, VIR_TYPED_PARAM_INT },
+#endif
 };
 
 
-- 
2.40.1

Re: [PATCH python] virDomainMigrate3Params: Add missing params

Posted by Michal Prívozník 10 months, 4 weeks ago

On 5/31/23 09:17, Han Han wrote:
> Add these missing migrate params:
> - VIR_MIGRATE_PARAM_DISKS_URI, since libvirt v6.8.0(49186372db)
> - VIR_MIGRATE_PARAM_TLS_DESTINATION, since libvirt v6.0.0(1b8af37213e)
> - VIR_MIGRATE_PARAM_COMPRESSION_ZLIB_LEVEL and VIR_MIGRATE_PARAM_COMPRESSION_ZSTD_LEVEL,
> since libvirt v9.4.0(150ae3e62b9)
> 
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
>  libvirt-override.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 

Thanks, I've created a MR:

https://gitlab.com/libvirt/libvirt-python/-/merge_requests/115

Michal