[libvirt PATCH 0/5] qemu: Find helpers at runtime

Andrea Bolognani posted 5 patches 11 months, 2 weeks ago
Failed in applying to current master (apply log)
meson.build                        | 24 ---------------
src/libvirt_private.syms           |  1 +
src/qemu/qemu.conf.in              |  8 +++--
src/qemu/qemu_conf.c               |  4 +++
src/qemu/qemu_interface.c          | 15 ++++++++--
src/qemu/qemu_process.c            | 17 ++++++++---
src/qemu/test_libvirtd_qemu.aug.in |  4 +--
src/util/virfile.c                 | 47 ++++++++++++++++++++++++++----
src/util/virfile.h                 |  3 ++
9 files changed, 83 insertions(+), 40 deletions(-)
[libvirt PATCH 0/5] qemu: Find helpers at runtime
Posted by Andrea Bolognani 11 months, 2 weeks ago
This removes the need to have them present in the build environment
and makes things more flexible.

Note that we currently *do not* have the helpers available in most CI
environments, or have BuildRequires for them in the spec file. That
only works for Fedora and RHEL because the hardcoded fallback paths
happen to match those used on those distributions: everywhere else,
the choice is to either ensure that the additional packages are
installed in the build environment or to produce a build of libvirt
that can't use the corresponding features out of the box.

Andrea Bolognani (5):
  util: Small refactor
  util: Introduce virFileFindInPathFull()
  qemu: Find helpers at runtime
  meson: Stop looking for QEMU helpers
  qemu: Update documentation for qemu.conf keys

 meson.build                        | 24 ---------------
 src/libvirt_private.syms           |  1 +
 src/qemu/qemu.conf.in              |  8 +++--
 src/qemu/qemu_conf.c               |  4 +++
 src/qemu/qemu_interface.c          | 15 ++++++++--
 src/qemu/qemu_process.c            | 17 ++++++++---
 src/qemu/test_libvirtd_qemu.aug.in |  4 +--
 src/util/virfile.c                 | 47 ++++++++++++++++++++++++++----
 src/util/virfile.h                 |  3 ++
 9 files changed, 83 insertions(+), 40 deletions(-)

-- 
2.40.1
Re: [libvirt PATCH 0/5] qemu: Find helpers at runtime
Posted by Martin Kletzander 11 months, 2 weeks ago
On Fri, May 05, 2023 at 08:01:41PM +0200, Andrea Bolognani wrote:
>This removes the need to have them present in the build environment
>and makes things more flexible.
>
>Note that we currently *do not* have the helpers available in most CI
>environments, or have BuildRequires for them in the spec file. That
>only works for Fedora and RHEL because the hardcoded fallback paths
>happen to match those used on those distributions: everywhere else,
>the choice is to either ensure that the additional packages are
>installed in the build environment or to produce a build of libvirt
>that can't use the corresponding features out of the box.
>
>Andrea Bolognani (5):
>  util: Small refactor
>  util: Introduce virFileFindInPathFull()
>  qemu: Find helpers at runtime
>  meson: Stop looking for QEMU helpers
>  qemu: Update documentation for qemu.conf keys

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

>
> meson.build                        | 24 ---------------
> src/libvirt_private.syms           |  1 +
> src/qemu/qemu.conf.in              |  8 +++--
> src/qemu/qemu_conf.c               |  4 +++
> src/qemu/qemu_interface.c          | 15 ++++++++--
> src/qemu/qemu_process.c            | 17 ++++++++---
> src/qemu/test_libvirtd_qemu.aug.in |  4 +--
> src/util/virfile.c                 | 47 ++++++++++++++++++++++++++----
> src/util/virfile.h                 |  3 ++
> 9 files changed, 83 insertions(+), 40 deletions(-)
>
>-- 
>2.40.1
>