qemu: tpm: Pass --logfile to swtpm_setup for incoming migration

[PATCH] qemu: tpm: Pass --logfile to swtpm_setup for incoming migration

Eiichi Tsukata posted 1 patch 1 year, 1 month ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20230310045918.17223-1-eiichi.tsukata@nutanix.com

src/qemu/qemu_tpm.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] qemu: tpm: Pass --logfile to swtpm_setup for incoming migration

Posted by Eiichi Tsukata 1 year, 1 month ago

Good to have for debugging in case something wrong happens during
incoming migration.

Signed-off-by: Eiichi Tsukata <eiichi.tsukata@nutanix.com>
---
 src/qemu/qemu_tpm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c
index 982e5f13b6..f4344de663 100644
--- a/src/qemu/qemu_tpm.c
+++ b/src/qemu/qemu_tpm.c
@@ -427,6 +427,7 @@ qemuTPMEmulatorRunSetup(const char *storagepath,
     } else {
         virCommandAddArgList(cmd,
                              "--tpm-state", storagepath,
+                             "--logfile", logfile,
                              "--overwrite",
                              NULL);
     }
-- 
2.39.2

Re: [PATCH] qemu: tpm: Pass --logfile to swtpm_setup for incoming migration

Posted by Michal Prívozník 1 year, 1 month ago

On 3/10/23 05:59, Eiichi Tsukata wrote:
> Good to have for debugging in case something wrong happens during
> incoming migration.
> 
> Signed-off-by: Eiichi Tsukata <eiichi.tsukata@nutanix.com>
> ---
>  src/qemu/qemu_tpm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
Yep, definitely worth it.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and pushed.

Michal