tests: Improve fakerootdir handling

[libvirt PATCH 0/4] tests: Improve fakerootdir handling

Andrea Bolognani posted 4 patches 1 year, 1 month ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20230301165446.598069-1-abologna@redhat.com

tests/qemuhotplugtest.c       | 15 ---------------
tests/qemumemlocktest.c       | 15 ---------------
tests/qemustatusxml2xmltest.c | 15 ---------------
tests/qemuxml2argvtest.c      | 15 ---------------
tests/qemuxml2xmltest.c       | 16 ----------------
tests/scsihosttest.c          | 14 +++-----------
tests/testutils.c             | 34 ++++++++++++++++++++++++++++++++++
tests/testutils.h             |  3 +++
tests/vircgrouptest.c         | 18 ++++--------------
tests/virhostdevtest.c        | 16 ----------------
tests/virpcitest.c            | 15 ---------------
11 files changed, 44 insertions(+), 132 deletions(-)

Expand all Fold all

[libvirt PATCH 0/4] tests: Improve fakerootdir handling

Posted by Andrea Bolognani 1 year, 1 month ago

I'd be open to squash patches 2 and 3 together, if that's
considered preferable by the reviewer.

Andrea Bolognani (4):
  tests: Introduce helpers for fakerootdir handling
  tests: Adopt fakerootdir helpers
  tests: Move fakerootdir handling to common logic
  tests: Print fakerootdir when it's preserved

 tests/qemuhotplugtest.c       | 15 ---------------
 tests/qemumemlocktest.c       | 15 ---------------
 tests/qemustatusxml2xmltest.c | 15 ---------------
 tests/qemuxml2argvtest.c      | 15 ---------------
 tests/qemuxml2xmltest.c       | 16 ----------------
 tests/scsihosttest.c          | 14 +++-----------
 tests/testutils.c             | 34 ++++++++++++++++++++++++++++++++++
 tests/testutils.h             |  3 +++
 tests/vircgrouptest.c         | 18 ++++--------------
 tests/virhostdevtest.c        | 16 ----------------
 tests/virpcitest.c            | 15 ---------------
 11 files changed, 44 insertions(+), 132 deletions(-)

-- 
2.39.2

Re: [libvirt PATCH 0/4] tests: Improve fakerootdir handling

Posted by Laine Stump 1 year, 1 month ago

On 3/1/23 11:54 AM, Andrea Bolognani wrote:
> I'd be open to squash patches 2 and 3 together, if that's
> considered preferable by the reviewer.
> 
> Andrea Bolognani (4):
>    tests: Introduce helpers for fakerootdir handling
>    tests: Adopt fakerootdir helpers
>    tests: Move fakerootdir handling to common logic
>    tests: Print fakerootdir when it's preserved

Reviewed-by: Laine Stump <laine@redhat.com>

> 
>   tests/qemuhotplugtest.c       | 15 ---------------
>   tests/qemumemlocktest.c       | 15 ---------------
>   tests/qemustatusxml2xmltest.c | 15 ---------------
>   tests/qemuxml2argvtest.c      | 15 ---------------
>   tests/qemuxml2xmltest.c       | 16 ----------------
>   tests/scsihosttest.c          | 14 +++-----------
>   tests/testutils.c             | 34 ++++++++++++++++++++++++++++++++++
>   tests/testutils.h             |  3 +++
>   tests/vircgrouptest.c         | 18 ++++--------------
>   tests/virhostdevtest.c        | 16 ----------------
>   tests/virpcitest.c            | 15 ---------------
>   11 files changed, 44 insertions(+), 132 deletions(-)
>