[libvirt PATCH] NEWS: Clarify limitations of passt support

Andrea Bolognani posted 1 patch 1 year, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20230228213433.341260-1-abologna@redhat.com
NEWS.rst | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
[libvirt PATCH] NEWS: Clarify limitations of passt support
Posted by Andrea Bolognani 1 year, 1 month ago
Let users know that we're working on lifting the limitations
and that they should not use the feature in production until
then.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 NEWS.rst | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/NEWS.rst b/NEWS.rst
index 683c147af0..b19c75ceac 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -79,7 +79,9 @@ v9.1.0 (unreleased)
     connectivity.
 
     (NB: On systems that use them, it is still necessary to disable
-    SELinux/AppArmor to start passt.)
+    SELinux/AppArmor to start passt. This is a temporary limitation,
+    and use of the feature in production is strongly discouraged
+    until it has been lifted.)
 
   * qemu: Fix error when attempting to change media in a CDROM drive
 
-- 
2.39.2
Re: [libvirt PATCH] NEWS: Clarify limitations of passt support
Posted by Laine Stump 1 year, 1 month ago
On 2/28/23 4:34 PM, Andrea Bolognani wrote:
> Let users know that we're working on lifting the limitations
> and that they should not use the feature in production until
> then.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>

Reviewed-by: Laine Stump <laine@redhat.com>

I think I like your version better, as it is less wordy, while also 
pointing out that this is something temporary that we are actively 
working to fix.

> ---
>   NEWS.rst | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/NEWS.rst b/NEWS.rst
> index 683c147af0..b19c75ceac 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -79,7 +79,9 @@ v9.1.0 (unreleased)
>       connectivity.
>   
>       (NB: On systems that use them, it is still necessary to disable
> -    SELinux/AppArmor to start passt.)
> +    SELinux/AppArmor to start passt. This is a temporary limitation,
> +    and use of the feature in production is strongly discouraged
> +    until it has been lifted.)
>   
>     * qemu: Fix error when attempting to change media in a CDROM drive
>
Re: [libvirt PATCH] NEWS: Clarify limitations of passt support
Posted by Andrea Bolognani 1 year, 1 month ago
On Tue, Feb 28, 2023 at 11:28:30PM -0500, Laine Stump wrote:
> On 2/28/23 4:34 PM, Andrea Bolognani wrote:
> > Let users know that we're working on lifting the limitations
> > and that they should not use the feature in production until
> > then.
> >
> > Signed-off-by: Andrea Bolognani <abologna@redhat.com>
>
> Reviewed-by: Laine Stump <laine@redhat.com>
>
> I think I like your version better, as it is less wordy, while also pointing
> out that this is something temporary that we are actively working to fix.

I didn't realize you already had posted a version before coming up
with mine :/ Anyway, pushed now.

-- 
Andrea Bolognani / Red Hat / Virtualization