Introduce active RBD disk snapshot support

[PATCH v2 0/6] Introduce active RBD disk snapshot support

Posted by Or Ozeri 1 year, 2 months ago

Internal disk snapshots are currently only supported on non-active VMs.
For RBD disks only, this patch series extends this support for active VMs running with qemu.
We also add the option to set a name for each RBD snapshot, and allow taking them alongside other external disk snapshots (mixing).
Deletion and reverting to snapshots containing RBD snapshots is not allowed, and is validated.
Note that taking RBD snapshots on a non-active VM is still unsupported.

Changes in v2:
    - reduce patch to RBD use-case only (e.g. not including qcow2 internal snapshots)
    - add validation to disallow RBD snapshots deletion / reverting

Or Ozeri (6):
  conf: Add snapshotName attribute for internal disk snapshot
  qemu: Block deletion and reverting on non-full internal snapshots
  qemu: Add internal support for active disk internal snapshots
  qemu: Allow active disk snapshots for RBD disks
  qemu: Allow setting per-disk snapshot name for RBD disks
  qemu: Allow mixing active internal and external active disk snapshots

 docs/formatsnapshot.rst                       |   5 +
 src/conf/schemas/domainsnapshot.rng           |   4 +
 src/conf/snapshot_conf.c                      |  56 ++++++++++
 src/conf/snapshot_conf.h                      |   5 +
 src/libvirt_private.syms                      |   1 +
 src/qemu/qemu_monitor.c                       |   9 ++
 src/qemu/qemu_monitor.h                       |   5 +
 src/qemu/qemu_monitor_json.c                  |  14 +++
 src/qemu/qemu_monitor_json.h                  |   5 +
 src/qemu/qemu_snapshot.c                      | 105 ++++++++++++------
 .../disk_snapshot.xml                         |   2 +-
 .../disk_snapshot.xml                         |   2 +-
 .../disk_snapshot_redefine.xml                |   2 +-
 tests/qemumonitorjsontest.c                   |   1 +
 14 files changed, 181 insertions(+), 35 deletions(-)

-- 
2.25.1

Re: [PATCH v2 0/6] Introduce active RBD disk snapshot support

Posted by Peter Krempa 1 year, 2 months ago

On Wed, Feb 15, 2023 at 05:28:16 -0600, Or Ozeri wrote:
> Internal disk snapshots are currently only supported on non-active VMs.
> For RBD disks only, this patch series extends this support for active VMs running with qemu.
> We also add the option to set a name for each RBD snapshot, and allow taking them alongside other external disk snapshots (mixing).
> Deletion and reverting to snapshots containing RBD snapshots is not allowed, and is validated.
> Note that taking RBD snapshots on a non-active VM is still unsupported.
> 
> Changes in v2:
>     - reduce patch to RBD use-case only (e.g. not including qcow2 internal snapshots)
>     - add validation to disallow RBD snapshots deletion / reverting
> 
> Or Ozeri (6):
>   conf: Add snapshotName attribute for internal disk snapshot
>   qemu: Block deletion and reverting on non-full internal snapshots
>   qemu: Add internal support for active disk internal snapshots
>   qemu: Allow active disk snapshots for RBD disks
>   qemu: Allow setting per-disk snapshot name for RBD disks
>   qemu: Allow mixing active internal and external active disk snapshots

Note that also Pavel (CC'd) might want to add more comments as he's
currently working on the snapshot code.

RE: [PATCH v2 0/6] Introduce active RBD disk snapshot support

Posted by Or Ozeri 1 year, 1 month ago

Hi Peter,

I'm missing some clarifications here:
https://listman.redhat.com/archives/libvir-list/2023-March/238546.html
https://listman.redhat.com/archives/libvir-list/2023-March/238548.html

Could you please have a look?

Thanks,
Or

> -----Original Message-----
> From: Peter Krempa <pkrempa@redhat.com>
> Sent: Monday, 20 February 2023 16:24
> To: Or Ozeri <ORO@il.ibm.com>
> Cc: libvir-list@redhat.com; Danny Harnik <DANNYH@il.ibm.com>; Pavel
> Hrdina <phrdina@redhat.com>
> Subject: [EXTERNAL] Re: [PATCH v2 0/6] Introduce active RBD disk snapshot
> support
> 
> On Wed, Feb 15, 2023 at 05:28:16 -0600, Or Ozeri wrote:
> > Internal disk snapshots are currently only supported on non-active VMs.
> > For RBD disks only, this patch series extends this support for active VMs
> running with qemu.
> > We also add the option to set a name for each RBD snapshot, and allow
> taking them alongside other external disk snapshots (mixing).
> > Deletion and reverting to snapshots containing RBD snapshots is not
> allowed, and is validated.
> > Note that taking RBD snapshots on a non-active VM is still unsupported.
> >
> > Changes in v2:
> >     - reduce patch to RBD use-case only (e.g. not including qcow2 internal
> snapshots)
> >     - add validation to disallow RBD snapshots deletion / reverting
> >
> > Or Ozeri (6):
> >   conf: Add snapshotName attribute for internal disk snapshot
> >   qemu: Block deletion and reverting on non-full internal snapshots
> >   qemu: Add internal support for active disk internal snapshots
> >   qemu: Allow active disk snapshots for RBD disks
> >   qemu: Allow setting per-disk snapshot name for RBD disks
> >   qemu: Allow mixing active internal and external active disk
> > snapshots
> 
> Note that also Pavel (CC'd) might want to add more comments as he's
> currently working on the snapshot code.