[v4] spec: Decompose the daemon subpackage

[PATCH V4 08/11] spec: Add numad dependency to qemu and lxc drivers

Posted by Jim Fehlig 3 years, 1 month ago

Both drivers use numad via virNumaGetAutoPlacementAdvice.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---
 libvirt.spec.in | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index e69005bb42..c5adb1a2ba 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -763,6 +763,9 @@ Requires: lzop
 Requires: xz
 Requires: systemd-container
 Requires: swtpm-tools
+    %if %{with_numad}
+Requires: numad
+    %endif
 
 %description daemon-driver-qemu
 The qemu driver plugin for the libvirtd daemon, providing
@@ -780,6 +783,9 @@ Requires: libvirt-daemon-driver-network = %{version}-%{release}
 Requires: systemd-container
 # for modprobe of nbd driver
 Requires: module-init-tools
+    %if %{with_numad}
+Requires: numad
+    %endif
 
 %description daemon-driver-lxc
 The LXC driver plugin for the libvirtd daemon, providing
-- 
2.38.1

Re: [PATCH V4 08/11] spec: Add numad dependency to qemu and lxc drivers

Posted by Andrea Bolognani 3 years, 1 month ago

On Thu, Dec 22, 2022 at 11:03:39AM -0700, Jim Fehlig wrote:
> Both drivers use numad via virNumaGetAutoPlacementAdvice.
>
> Signed-off-by: Jim Fehlig <jfehlig@suse.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  libvirt.spec.in | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index e69005bb42..c5adb1a2ba 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -763,6 +763,9 @@ Requires: lzop
>  Requires: xz
>  Requires: systemd-container
>  Requires: swtpm-tools
> +    %if %{with_numad}
> +Requires: numad
> +    %endif
>
>  %description daemon-driver-qemu
>  The qemu driver plugin for the libvirtd daemon, providing
> @@ -780,6 +783,9 @@ Requires: libvirt-daemon-driver-network = %{version}-%{release}
>  Requires: systemd-container
>  # for modprobe of nbd driver
>  Requires: module-init-tools
> +    %if %{with_numad}
> +Requires: numad
> +    %endif

Same comment as the previous patch: I think you should be able to
drop the dependency on numad from the libvirt-daemon package at this
point.

-- 
Andrea Bolognani / Red Hat / Virtualization