The storage-backend/ and storage-file/ directories are currently
considered unowned by RPM. Have the libvirt-daemon package take
ownership of them, just as it already owns the connection-driver/
and lock-driver/ directories.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 libvirt.spec.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index cf619e1b59..6b8acf252e 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1762,6 +1762,8 @@ exit 0
 %dir %attr(0755, root, root) %{_libdir}/libvirt/
 %dir %attr(0755, root, root) %{_libdir}/libvirt/connection-driver/
 %dir %attr(0755, root, root) %{_libdir}/libvirt/lock-driver/
+%dir %attr(0755, root, root) %{_libdir}/libvirt/storage-backend/
+%dir %attr(0755, root, root) %{_libdir}/libvirt/storage-file/
 %attr(0755, root, root) %{_libdir}/libvirt/lock-driver/lockd.so
 %{_datadir}/augeas/lenses/libvirtd.aug
 %{_datadir}/augeas/lenses/tests/test_libvirtd.aug
-- 
2.38.1

On 12/13/22 03:58, Andrea Bolognani wrote:
> The storage-backend/ and storage-file/ directories are currently
> considered unowned by RPM. Have the libvirt-daemon package take
> ownership of them, just as it already owns the connection-driver/
> and lock-driver/ directories.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>   libvirt.spec.in | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index cf619e1b59..6b8acf252e 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -1762,6 +1762,8 @@ exit 0
>   %dir %attr(0755, root, root) %{_libdir}/libvirt/
>   %dir %attr(0755, root, root) %{_libdir}/libvirt/connection-driver/
>   %dir %attr(0755, root, root) %{_libdir}/libvirt/lock-driver/
> +%dir %attr(0755, root, root) %{_libdir}/libvirt/storage-backend/
> +%dir %attr(0755, root, root) %{_libdir}/libvirt/storage-file/

Can these new items be added to libvirt-daemon-driver-storage-core? Otherwise 
I'm pretty sure I'll be moving them there in my series :-).

Regards,
Jim

On Tue, Dec 13, 2022 at 04:37:34PM -0700, Jim Fehlig wrote:
> On 12/13/22 03:58, Andrea Bolognani wrote:
> >   %dir %attr(0755, root, root) %{_libdir}/libvirt/
> >   %dir %attr(0755, root, root) %{_libdir}/libvirt/connection-driver/
> >   %dir %attr(0755, root, root) %{_libdir}/libvirt/lock-driver/
> > +%dir %attr(0755, root, root) %{_libdir}/libvirt/storage-backend/
> > +%dir %attr(0755, root, root) %{_libdir}/libvirt/storage-file/
>
> Can these new items be added to libvirt-daemon-driver-storage-core?
> Otherwise I'm pretty sure I'll be moving them there in my series :-).

The idea was exactly that you'd be moving them to
libvirt-daemon-common in your series, along with the other two :)

-- 
Andrea Bolognani / Red Hat / Virtualization

On 12/14/22 04:25, Andrea Bolognani wrote:
> On Tue, Dec 13, 2022 at 04:37:34PM -0700, Jim Fehlig wrote:
>> On 12/13/22 03:58, Andrea Bolognani wrote:
>>>    %dir %attr(0755, root, root) %{_libdir}/libvirt/
>>>    %dir %attr(0755, root, root) %{_libdir}/libvirt/connection-driver/
>>>    %dir %attr(0755, root, root) %{_libdir}/libvirt/lock-driver/
>>> +%dir %attr(0755, root, root) %{_libdir}/libvirt/storage-backend/
>>> +%dir %attr(0755, root, root) %{_libdir}/libvirt/storage-file/
>>
>> Can these new items be added to libvirt-daemon-driver-storage-core?
>> Otherwise I'm pretty sure I'll be moving them there in my series :-).
> 
> The idea was exactly that you'd be moving them to
> libvirt-daemon-common in your series, along with the other two :)
> 

Since they are new additions seems they could be moved to the "correct" place 
straight away. But I'm fine moving them too.

Reviewed-by: Jim Fehlig <jfehlig@suse.com>

Regards,
Jim

On Wed, Dec 14, 2022 at 07:53:05AM -0700, Jim Fehlig wrote:
> On 12/14/22 04:25, Andrea Bolognani wrote:
> > On Tue, Dec 13, 2022 at 04:37:34PM -0700, Jim Fehlig wrote:
> > > On 12/13/22 03:58, Andrea Bolognani wrote:
> > > >    %dir %attr(0755, root, root) %{_libdir}/libvirt/
> > > >    %dir %attr(0755, root, root) %{_libdir}/libvirt/connection-driver/
> > > >    %dir %attr(0755, root, root) %{_libdir}/libvirt/lock-driver/
> > > > +%dir %attr(0755, root, root) %{_libdir}/libvirt/storage-backend/
> > > > +%dir %attr(0755, root, root) %{_libdir}/libvirt/storage-file/
> > >
> > > Can these new items be added to libvirt-daemon-driver-storage-core?
> > > Otherwise I'm pretty sure I'll be moving them there in my series :-).
> >
> > The idea was exactly that you'd be moving them to
> > libvirt-daemon-common in your series, along with the other two :)
>
> Since they are new additions seems they could be moved to the "correct"
> place straight away. But I'm fine moving them too.

Pushed now, as it's an improvement that's completely independent from
your upcoming changes and you're going to need at least another
respin for those anyway. Thanks for the review!

-- 
Andrea Bolognani / Red Hat / Virtualization