[PATCH] virsh: Add message to terminal when running snapshot-revert

Haruka Ohata posted 1 patch 1 week, 5 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20221122074115.76770-1-ohata.haruka@fujitsu.com
There is a newer version of this series
tests/virsh-snapshot   | 3 +++
tools/virsh-snapshot.c | 1 +
2 files changed, 4 insertions(+)
[PATCH] virsh: Add message to terminal when running snapshot-revert
Posted by Haruka Ohata 1 week, 5 days ago
When running virsh snapshot-* command, such as
snapshot-create-as / snapshot-delete, it prints a result message.
On the other hand virsh snapshot-revert command doesn't print a result
message.

So, This patch fixes to add message when running virsh snapshot-revert
command.
---
    # virsh snapshot-create-as vm1 test1
    Domain snapshot test01 created
    # virsh snapshot-revert vm1 test1

    # virsh snapshot-delete vm1 test1
    Domain snapshot test01 deleted

    #
---

Signed-off-by: Haruka Ohata <ohata.haruka@fujitsu.com>
---
 tests/virsh-snapshot   | 3 +++
 tools/virsh-snapshot.c | 1 +
 2 files changed, 4 insertions(+)

diff --git a/tests/virsh-snapshot b/tests/virsh-snapshot
index 4c64bb537b..b09273917b 100755
--- a/tests/virsh-snapshot
+++ b/tests/virsh-snapshot
@@ -100,11 +100,14 @@ Domain snapshot s1 created
 
 Domain snapshot s3 created
 Domain snapshot s2 created
+Domain snapshot s3 reverted
 
 Domain snapshot s6 created
 Domain snapshot s5 created
+Domain snapshot s6 reverted
 
 Domain snapshot s4 created
+Domain snapshot s1 reverted
 
 Domain snapshot s7 created
 Domain snapshot s8 created
diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c
index 8fa64ba903..6a6c92d0a3 100644
--- a/tools/virsh-snapshot.c
+++ b/tools/virsh-snapshot.c
@@ -1783,6 +1783,7 @@ cmdDomainSnapshotRevert(vshControl *ctl, const vshCmd *cmd)
         result = virDomainRevertToSnapshot(snapshot, flags);
     }
 
+    vshPrintExtra(ctl, _("Domain snapshot %s reverted\n"), name);
     return result >= 0;
 }
 
-- 
2.38.1
Re: [PATCH] virsh: Add message to terminal when running snapshot-revert
Posted by Ján Tomko 1 week, 5 days ago
On a Tuesday in 2022, Haruka Ohata wrote:
>When running virsh snapshot-* command, such as
>snapshot-create-as / snapshot-delete, it prints a result message.
>On the other hand virsh snapshot-revert command doesn't print a result
>message.
>
>So, This patch fixes to add message when running virsh snapshot-revert
>command.
>---
>    # virsh snapshot-create-as vm1 test1
>    Domain snapshot test01 created
>    # virsh snapshot-revert vm1 test1
>
>    # virsh snapshot-delete vm1 test1
>    Domain snapshot test01 deleted
>
>    #
>---
>
>Signed-off-by: Haruka Ohata <ohata.haruka@fujitsu.com>
>---
> tests/virsh-snapshot   | 3 +++
> tools/virsh-snapshot.c | 1 +
> 2 files changed, 4 insertions(+)
>
>diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c
>index 8fa64ba903..6a6c92d0a3 100644
>--- a/tools/virsh-snapshot.c
>+++ b/tools/virsh-snapshot.c
>@@ -1783,6 +1783,7 @@ cmdDomainSnapshotRevert(vshControl *ctl, const vshCmd *cmd)
>         result = virDomainRevertToSnapshot(snapshot, flags);
>     }
>
>+    vshPrintExtra(ctl, _("Domain snapshot %s reverted\n"), name);
>     return result >= 0;

This would print the message regardless of what the
virDomainRevertToSnapshot API would return.

Looks like we need to return the value the way it was done before
commit 19b77df5cc0b7577cb5b045c76f8b79221f32ac0

Jano

> }
>
>-- 
>2.38.1
>