[libvirt PATCH][pushed] Fix spelling

Tim Wiederhake posted 1 patch 1 year, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20221111155058.18287-1-twiederh@redhat.com
NEWS.rst                | 2 +-
src/qemu/qemu.conf.in   | 2 +-
src/qemu/qemu_monitor.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
[libvirt PATCH][pushed] Fix spelling
Posted by Tim Wiederhake 1 year, 5 months ago
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
---
 NEWS.rst                | 2 +-
 src/qemu/qemu.conf.in   | 2 +-
 src/qemu/qemu_monitor.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/NEWS.rst b/NEWS.rst
index e584bc1fed..2ce8ef4b6a 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -218,7 +218,7 @@ v8.5.0 (2022-07-01)
   * qemu: Add support for zero-copy migration
 
     With QEMU 7.1.0, libvirt can enable zerocopy for parallel migration. This
-    is implmented by adding a new ``VIR_MIGRATE_ZEROCOPY`` flag(``virsh migrate
+    is implemented by adding a new ``VIR_MIGRATE_ZEROCOPY`` flag(``virsh migrate
     --zerocopy``).
 
   * Introduce thread_pool_min and thread_pool_max attributes to IOThread
diff --git a/src/qemu/qemu.conf.in b/src/qemu/qemu.conf.in
index 623da72d60..3895d42514 100644
--- a/src/qemu/qemu.conf.in
+++ b/src/qemu/qemu.conf.in
@@ -963,7 +963,7 @@
 # "vcpus"    - only QEMU vCPU threads are placed into a separate scheduling group,
 #              emulator threads and helper processes remain outside of the group
 # "emulator" - only QEMU and its threads (emulator + vCPUs) are placed into
-#              separate scheduling group, helper proccesses remain outside of
+#              separate scheduling group, helper processes remain outside of
 #              the group
 # "full"    -  both QEMU and its helper processes are placed into separate
 #              scheduling group
diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index 8ada16154c..80f262cec7 100644
--- a/src/qemu/qemu_monitor.c
+++ b/src/qemu/qemu_monitor.c
@@ -4346,7 +4346,7 @@ qemuMonitorQueryStatsProviderNew(qemuMonitorQueryStatsProviderType provider_type
 
     /*
      * This can be lowered later in case of the enum getting quite large, hence
-     *  the virBitmapSetExpand below which also incidently makes this function
+     *  the virBitmapSetExpand below which also incidentally makes this function
      *  non-fallible.
      */
     provider->names = virBitmapNew(QEMU_MONITOR_QUERY_STATS_NAME_LAST);
-- 
2.36.1
Re: [libvirt PATCH][pushed] Fix spelling
Posted by Martin Kletzander 1 year, 5 months ago
On Fri, Nov 11, 2022 at 04:50:58PM +0100, Tim Wiederhake wrote:
>Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
>---
> NEWS.rst                | 2 +-
> src/qemu/qemu.conf.in   | 2 +-
> src/qemu/qemu_monitor.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/NEWS.rst b/NEWS.rst
>index e584bc1fed..2ce8ef4b6a 100644
>--- a/NEWS.rst
>+++ b/NEWS.rst
>@@ -218,7 +218,7 @@ v8.5.0 (2022-07-01)
>   * qemu: Add support for zero-copy migration
>
>     With QEMU 7.1.0, libvirt can enable zerocopy for parallel migration. This
>-    is implmented by adding a new ``VIR_MIGRATE_ZEROCOPY`` flag(``virsh migrate
>+    is implemented by adding a new ``VIR_MIGRATE_ZEROCOPY`` flag(``virsh migrate
>     --zerocopy``).
>
>   * Introduce thread_pool_min and thread_pool_max attributes to IOThread
>diff --git a/src/qemu/qemu.conf.in b/src/qemu/qemu.conf.in
>index 623da72d60..3895d42514 100644
>--- a/src/qemu/qemu.conf.in
>+++ b/src/qemu/qemu.conf.in
>@@ -963,7 +963,7 @@
> # "vcpus"    - only QEMU vCPU threads are placed into a separate scheduling group,
> #              emulator threads and helper processes remain outside of the group
> # "emulator" - only QEMU and its threads (emulator + vCPUs) are placed into
>-#              separate scheduling group, helper proccesses remain outside of
>+#              separate scheduling group, helper processes remain outside of
> #              the group
> # "full"    -  both QEMU and its helper processes are placed into separate
> #              scheduling group
>diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
>index 8ada16154c..80f262cec7 100644
>--- a/src/qemu/qemu_monitor.c
>+++ b/src/qemu/qemu_monitor.c
>@@ -4346,7 +4346,7 @@ qemuMonitorQueryStatsProviderNew(qemuMonitorQueryStatsProviderType provider_type
>
>     /*
>      * This can be lowered later in case of the enum getting quite large, hence
>-     *  the virBitmapSetExpand below which also incidently makes this function
>+     *  the virBitmapSetExpand below which also incidentally makes this function
>      *  non-fallible.

These three lines should also be indented properly, I think you can
squash it it.

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>


>      */
>     provider->names = virBitmapNew(QEMU_MONITOR_QUERY_STATS_NAME_LAST);
>-- 
>2.36.1
>