[PATCH 1/3] NEWS: Mention UNDEFINE_TPM and UNDEFINE_KEEP_TPM flags

Han Han posted 3 patches 3 years, 3 months ago
[PATCH 1/3] NEWS: Mention UNDEFINE_TPM and UNDEFINE_KEEP_TPM flags
Posted by Han Han 3 years, 3 months ago
Signed-off-by: Han Han <hhan@redhat.com>
---
 NEWS.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/NEWS.rst b/NEWS.rst
index 893ad6f370..1d4fb62d5e 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -17,6 +17,13 @@ v8.9.0 (unreleased)
 
 * **New features**
 
+  * qemu: Add flags to keep or remove TPM state for the virDomainUndefineFlags
+
+    ``VIR_DOMAIN_UNDEFINE_TPM`` and ``VIR_DOMAIN_UNDEFINE_KEEP_TPM`` specify
+    accordingly to delete or keep a TPM's persistent state directory structure
+    and files when undefine a domain. In virsh, they are the ``--tpm`` and
+    ``--keep-tpm`` for the sub-command undefine.
+
   * qemu: Core Scheduling support
 
     To avoid side channel attacks, the Linux kernel allows creating groups of
-- 
2.38.1
Re: [PATCH 1/3] NEWS: Mention UNDEFINE_TPM and UNDEFINE_KEEP_TPM flags
Posted by Peter Krempa 3 years, 3 months ago
On Tue, Nov 01, 2022 at 13:49:10 +0800, Han Han wrote:
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
>  NEWS.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/NEWS.rst b/NEWS.rst
> index 893ad6f370..1d4fb62d5e 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -17,6 +17,13 @@ v8.9.0 (unreleased)
>  
>  * **New features**
>  
> +  * qemu: Add flags to keep or remove TPM state for the virDomainUndefineFlags
> +
> +    ``VIR_DOMAIN_UNDEFINE_TPM`` and ``VIR_DOMAIN_UNDEFINE_KEEP_TPM`` specify
> +    accordingly to delete or keep a TPM's persistent state directory structure
> +    and files when undefine a domain. In virsh, they are the ``--tpm`` and
> +    ``--keep-tpm`` for the sub-command undefine.
> +

I'll reword this as:

  * qemu: Add flags to keep or remove TPM state for ``virDomainUndefineFlags``

    ``VIR_DOMAIN_UNDEFINE_TPM`` and ``VIR_DOMAIN_UNDEFINE_KEEP_TPM`` specify
    accordingly to delete or keep a TPM's persistent state directory structure
    and files when undefining a domain. In virsh the flags are exposed as
    ``--tpm`` and ``--keep-tpm`` for the sub-command ``undefine``.


and I'll put it under the 'Improvements' section.