[v1] Synchronize x86 cpu features from qemu

[libvirt PATCH 10/28] cpu_map: Add missing x86 feature "sgx1"

Posted by Tim Wiederhake 3 years, 3 months ago

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
---
 src/cpu_map/x86_features.xml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml
index 5b9e61a3d0..aa3d6958bf 100644
--- a/src/cpu_map/x86_features.xml
+++ b/src/cpu_map/x86_features.xml
@@ -415,6 +415,10 @@
     <cpuid eax_in='0x12' ecx_in='0x00' ebx='0x00000001'/>
   </feature>
 
+  <feature name='sgx1'>
+    <cpuid eax_in='0x12' ecx_in='0x00' ecx='0x00000001'/>
+  </feature>
+
   <!-- extended features, EDX -->
   <feature name='syscall'>
     <cpuid eax_in='0x80000001' edx='0x00000800'/>
-- 
2.36.1

Re: [libvirt PATCH 10/28] cpu_map: Add missing x86 feature "sgx1"

Posted by Jiri Denemark 3 years, 3 months ago

On Wed, Oct 19, 2022 at 18:56:10 +0200, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
> ---
>  src/cpu_map/x86_features.xml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml
> index 5b9e61a3d0..aa3d6958bf 100644
> --- a/src/cpu_map/x86_features.xml
> +++ b/src/cpu_map/x86_features.xml
> @@ -415,6 +415,10 @@
>      <cpuid eax_in='0x12' ecx_in='0x00' ebx='0x00000001'/>
>    </feature>
>  
> +  <feature name='sgx1'>
> +    <cpuid eax_in='0x12' ecx_in='0x00' ecx='0x00000001'/>
> +  </feature>

QEMU defines this in FEAT_SGX_12_0_EAX (.cpuid.reg = R_EAX) while you
have 'ecx'

Jirka