Hi,

This series updates the remaining pseries tests in qemuxml2argvtest.c to
use CAPS_LATEST instead of using a capability list for each test.

First patch is the usual capability bump for the new QEMU release.
Second patch converts the most simple cases of DO_TEST() to use
DO_TEST_CAPS_LATEST(). The patch is rather big but the changes are
trivial.

Third patch is a change I figured it was worth making to avoid using
DO_TEST() in the pseries feature parse error tests.

After applying this series, there is no more DO_TEST() tests with
'pseries' in the name in qemuxml2argvtest.c.

Daniel Henrique Barboza (3):
  tests: qemucapabilities: bump ppc64 caps with qemu 7.1.0
  tests: change qemuxml2argv pseries tests to TEST_CAPS_LATEST
  tests: refactor pseries features parse failure tests

 tests/domaincapsdata/qemu_7.1.0.ppc64.xml     |   147 +
 .../caps_7.1.0.ppc64.replies                  | 35113 ++++++++++++++++
 .../qemucapabilitiesdata/caps_7.1.0.ppc64.xml |  1109 +
 ...s.args => pseries-basic.ppc64-latest.args} |    11 +-
 .../pseries-console-native.args               |     1 -
 .../pseries-console-native.ppc64-latest.args  |     1 +
 ... pseries-console-virtio.ppc64-latest.args} |    11 +-
 ...s => pseries-cpu-compat.ppc64-latest.args} |    10 +-
 ...gs => pseries-cpu-exact.ppc64-latest.args} |    10 +-
 ....args => pseries-cpu-le.ppc64-latest.args} |    11 +-
 ...es-default-phb-numa-node.ppc64-latest.err} |     0
 .../qemuxml2argvdata/pseries-features-ccf.xml |    15 +-
 .../pseries-features-cfpc.xml                 |    15 +-
 .../pseries-features-hpt-pagesize.xml         |    17 +-
 .../qemuxml2argvdata/pseries-features-htm.xml |    15 +-
 .../qemuxml2argvdata/pseries-features-ibs.xml |    15 +-
 .../pseries-features-nested-hv.xml            |    15 +-
 .../pseries-features-sbbc.xml                 |    15 +-
 ...rgs => pseries-features.ppc64-latest.args} |     7 +-
 .../pseries-hostdevs-1.ppc64-latest.args      |    36 +
 .../pseries-hostdevs-2.ppc64-latest.args      |    36 +
 .../qemuxml2argvdata/pseries-hostdevs-3.args  |    32 -
 .../pseries-hostdevs-3.ppc64-latest.args      |    35 +
 .../pseries-many-buses-1.args                 |    30 -
 ...=> pseries-many-buses-1.ppc64-latest.args} |    14 +-
 .../pseries-many-buses-2.args                 |    30 -
 ...=> pseries-many-buses-2.ppc64-latest.args} |    14 +-
 .../pseries-many-devices.args                 |    61 -
 .../pseries-many-devices.ppc64-latest.args    |    64 +
 ...m.args => pseries-nvram.ppc64-latest.args} |     9 +-
 ...=> pseries-panic-address.ppc64-latest.err} |     0
 .../pseries-panic-missing.ppc64-latest.args   |    34 +
 ...pseries-panic-no-address.ppc64-latest.args |    34 +
 .../pseries-phb-default-missing.args          |    30 -
 ...ies-phb-default-missing.ppc64-latest.args} |    12 +-
 ...> pseries-phb-numa-node.ppc64-latest.args} |    16 +-
 .../qemuxml2argvdata/pseries-phb-simple.args  |    30 -
 ...s => pseries-phb-simple.ppc64-latest.args} |    12 +-
 .../pseries-serial+console-native.args        |     1 -
 ...es-serial+console-native.ppc64-latest.args |     1 +
 .../pseries-serial-compat.args                |     1 -
 .../pseries-serial-compat.ppc64-latest.args   |     1 +
 ...> pseries-serial-native.ppc64-latest.args} |     9 +-
 ...s => pseries-serial-pci.ppc64-latest.args} |     9 +-
 ...s => pseries-serial-usb.ppc64-latest.args} |    11 +-
 .../qemuxml2argvdata/pseries-usb-default.args |    31 -
 .../pseries-usb-default.ppc64-latest.args     |    34 +
 tests/qemuxml2argvdata/pseries-usb-kbd.args   |    32 -
 .../pseries-usb-kbd.ppc64-latest.args         |    35 +
 tests/qemuxml2argvdata/pseries-usb-multi.args |    32 -
 .../pseries-usb-multi.ppc64-latest.args       |    35 +
 ...eries-vio-user-assigned.ppc64-latest.args} |    19 +-
 ...ned.args => pseries-vio.ppc64-latest.args} |    19 +-
 tests/qemuxml2argvtest.c                      |   213 +-
 54 files changed, 36978 insertions(+), 572 deletions(-)
 create mode 100644 tests/domaincapsdata/qemu_7.1.0.ppc64.xml
 create mode 100644 tests/qemucapabilitiesdata/caps_7.1.0.ppc64.replies
 create mode 100644 tests/qemucapabilitiesdata/caps_7.1.0.ppc64.xml
 rename tests/qemuxml2argvdata/{pseries-panic-no-address.args => pseries-basic.ppc64-latest.args} (58%)
 delete mode 120000 tests/qemuxml2argvdata/pseries-console-native.args
 create mode 120000 tests/qemuxml2argvdata/pseries-console-native.ppc64-latest.args
 rename tests/qemuxml2argvdata/{pseries-console-virtio.args => pseries-console-virtio.ppc64-latest.args} (57%)
 rename tests/qemuxml2argvdata/{pseries-cpu-compat.args => pseries-cpu-compat.ppc64-latest.args} (58%)
 rename tests/qemuxml2argvdata/{pseries-cpu-exact.args => pseries-cpu-exact.ppc64-latest.args} (59%)
 rename tests/qemuxml2argvdata/{pseries-cpu-le.args => pseries-cpu-le.ppc64-latest.args} (58%)
 rename tests/qemuxml2argvdata/{pseries-default-phb-numa-node.err => pseries-default-phb-numa-node.ppc64-latest.err} (100%)
 mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-features-ccf.xml
 mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-features-cfpc.xml
 mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-features-hpt-pagesize.xml
 mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-features-htm.xml
 mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-features-ibs.xml
 mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-features-nested-hv.xml
 mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-features-sbbc.xml
 rename tests/qemuxml2argvdata/{pseries-features.args => pseries-features.ppc64-latest.args} (68%)
 create mode 100644 tests/qemuxml2argvdata/pseries-hostdevs-1.ppc64-latest.args
 create mode 100644 tests/qemuxml2argvdata/pseries-hostdevs-2.ppc64-latest.args
 delete mode 100644 tests/qemuxml2argvdata/pseries-hostdevs-3.args
 create mode 100644 tests/qemuxml2argvdata/pseries-hostdevs-3.ppc64-latest.args
 delete mode 100644 tests/qemuxml2argvdata/pseries-many-buses-1.args
 rename tests/qemuxml2argvdata/{pseries-hostdevs-2.args => pseries-many-buses-1.ppc64-latest.args} (57%)
 delete mode 100644 tests/qemuxml2argvdata/pseries-many-buses-2.args
 rename tests/qemuxml2argvdata/{pseries-hostdevs-1.args => pseries-many-buses-2.ppc64-latest.args} (58%)
 delete mode 100644 tests/qemuxml2argvdata/pseries-many-devices.args
 create mode 100644 tests/qemuxml2argvdata/pseries-many-devices.ppc64-latest.args
 rename tests/qemuxml2argvdata/{pseries-nvram.args => pseries-nvram.ppc64-latest.args} (63%)
 rename tests/qemuxml2argvdata/{pseries-panic-address.err => pseries-panic-address.ppc64-latest.err} (100%)
 create mode 100644 tests/qemuxml2argvdata/pseries-panic-missing.ppc64-latest.args
 create mode 100644 tests/qemuxml2argvdata/pseries-panic-no-address.ppc64-latest.args
 delete mode 100644 tests/qemuxml2argvdata/pseries-phb-default-missing.args
 rename tests/qemuxml2argvdata/{pseries-basic.args => pseries-phb-default-missing.ppc64-latest.args} (58%)
 rename tests/qemuxml2argvdata/{pseries-phb-numa-node.args => pseries-phb-numa-node.ppc64-latest.args} (53%)
 delete mode 100644 tests/qemuxml2argvdata/pseries-phb-simple.args
 rename tests/qemuxml2argvdata/{pseries-panic-missing.args => pseries-phb-simple.ppc64-latest.args} (58%)
 delete mode 120000 tests/qemuxml2argvdata/pseries-serial+console-native.args
 create mode 120000 tests/qemuxml2argvdata/pseries-serial+console-native.ppc64-latest.args
 delete mode 120000 tests/qemuxml2argvdata/pseries-serial-compat.args
 create mode 120000 tests/qemuxml2argvdata/pseries-serial-compat.ppc64-latest.args
 rename tests/qemuxml2argvdata/{pseries-serial-native.args => pseries-serial-native.ppc64-latest.args} (61%)
 rename tests/qemuxml2argvdata/{pseries-serial-pci.args => pseries-serial-pci.ppc64-latest.args} (60%)
 rename tests/qemuxml2argvdata/{pseries-serial-usb.args => pseries-serial-usb.ppc64-latest.args} (57%)
 delete mode 100644 tests/qemuxml2argvdata/pseries-usb-default.args
 create mode 100644 tests/qemuxml2argvdata/pseries-usb-default.ppc64-latest.args
 delete mode 100644 tests/qemuxml2argvdata/pseries-usb-kbd.args
 create mode 100644 tests/qemuxml2argvdata/pseries-usb-kbd.ppc64-latest.args
 delete mode 100644 tests/qemuxml2argvdata/pseries-usb-multi.args
 create mode 100644 tests/qemuxml2argvdata/pseries-usb-multi.ppc64-latest.args
 rename tests/qemuxml2argvdata/{pseries-vio.args => pseries-vio-user-assigned.ppc64-latest.args} (52%)
 rename tests/qemuxml2argvdata/{pseries-vio-user-assigned.args => pseries-vio.ppc64-latest.args} (52%)

-- 
2.37.3

On 9/19/22 18:39, Daniel Henrique Barboza wrote:
> Hi,
> 
> This series updates the remaining pseries tests in qemuxml2argvtest.c to
> use CAPS_LATEST instead of using a capability list for each test.
> 
> First patch is the usual capability bump for the new QEMU release.
> Second patch converts the most simple cases of DO_TEST() to use
> DO_TEST_CAPS_LATEST(). The patch is rather big but the changes are
> trivial.
> 
> Third patch is a change I figured it was worth making to avoid using
> DO_TEST() in the pseries feature parse error tests.
> 
> After applying this series, there is no more DO_TEST() tests with
> 'pseries' in the name in qemuxml2argvtest.c.
> 
> Daniel Henrique Barboza (3):
>   tests: qemucapabilities: bump ppc64 caps with qemu 7.1.0
>   tests: change qemuxml2argv pseries tests to TEST_CAPS_LATEST
>   tests: refactor pseries features parse failure tests
> 
>  54 files changed, 36978 insertions(+), 572 deletions(-)

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Sorry for the delay.

Michal

On 10/13/22 08:02, Michal Prívozník wrote:
> On 9/19/22 18:39, Daniel Henrique Barboza wrote:
>> Hi,
>>
>> This series updates the remaining pseries tests in qemuxml2argvtest.c to
>> use CAPS_LATEST instead of using a capability list for each test.
>>
>> First patch is the usual capability bump for the new QEMU release.
>> Second patch converts the most simple cases of DO_TEST() to use
>> DO_TEST_CAPS_LATEST(). The patch is rather big but the changes are
>> trivial.
>>
>> Third patch is a change I figured it was worth making to avoid using
>> DO_TEST() in the pseries feature parse error tests.
>>
>> After applying this series, there is no more DO_TEST() tests with
>> 'pseries' in the name in qemuxml2argvtest.c.
>>
>> Daniel Henrique Barboza (3):
>>    tests: qemucapabilities: bump ppc64 caps with qemu 7.1.0
>>    tests: change qemuxml2argv pseries tests to TEST_CAPS_LATEST
>>    tests: refactor pseries features parse failure tests
>>
>>   54 files changed, 36978 insertions(+), 572 deletions(-)
> 
> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
> 
> Sorry for the delay.

Thanks Michal!

Pushed after squashing the patch 1 changes.


Thanks,


Daniel

> 
> Michal
> 

Ping

On 9/19/22 13:39, Daniel Henrique Barboza wrote:
> Hi,
> 
> This series updates the remaining pseries tests in qemuxml2argvtest.c to
> use CAPS_LATEST instead of using a capability list for each test.
> 
> First patch is the usual capability bump for the new QEMU release.
> Second patch converts the most simple cases of DO_TEST() to use
> DO_TEST_CAPS_LATEST(). The patch is rather big but the changes are
> trivial.
> 
> Third patch is a change I figured it was worth making to avoid using
> DO_TEST() in the pseries feature parse error tests.
> 
> After applying this series, there is no more DO_TEST() tests with
> 'pseries' in the name in qemuxml2argvtest.c.
> 
> Daniel Henrique Barboza (3):
>    tests: qemucapabilities: bump ppc64 caps with qemu 7.1.0
>    tests: change qemuxml2argv pseries tests to TEST_CAPS_LATEST
>    tests: refactor pseries features parse failure tests
> 
>   tests/domaincapsdata/qemu_7.1.0.ppc64.xml     |   147 +
>   .../caps_7.1.0.ppc64.replies                  | 35113 ++++++++++++++++
>   .../qemucapabilitiesdata/caps_7.1.0.ppc64.xml |  1109 +
>   ...s.args => pseries-basic.ppc64-latest.args} |    11 +-
>   .../pseries-console-native.args               |     1 -
>   .../pseries-console-native.ppc64-latest.args  |     1 +
>   ... pseries-console-virtio.ppc64-latest.args} |    11 +-
>   ...s => pseries-cpu-compat.ppc64-latest.args} |    10 +-
>   ...gs => pseries-cpu-exact.ppc64-latest.args} |    10 +-
>   ....args => pseries-cpu-le.ppc64-latest.args} |    11 +-
>   ...es-default-phb-numa-node.ppc64-latest.err} |     0
>   .../qemuxml2argvdata/pseries-features-ccf.xml |    15 +-
>   .../pseries-features-cfpc.xml                 |    15 +-
>   .../pseries-features-hpt-pagesize.xml         |    17 +-
>   .../qemuxml2argvdata/pseries-features-htm.xml |    15 +-
>   .../qemuxml2argvdata/pseries-features-ibs.xml |    15 +-
>   .../pseries-features-nested-hv.xml            |    15 +-
>   .../pseries-features-sbbc.xml                 |    15 +-
>   ...rgs => pseries-features.ppc64-latest.args} |     7 +-
>   .../pseries-hostdevs-1.ppc64-latest.args      |    36 +
>   .../pseries-hostdevs-2.ppc64-latest.args      |    36 +
>   .../qemuxml2argvdata/pseries-hostdevs-3.args  |    32 -
>   .../pseries-hostdevs-3.ppc64-latest.args      |    35 +
>   .../pseries-many-buses-1.args                 |    30 -
>   ...=> pseries-many-buses-1.ppc64-latest.args} |    14 +-
>   .../pseries-many-buses-2.args                 |    30 -
>   ...=> pseries-many-buses-2.ppc64-latest.args} |    14 +-
>   .../pseries-many-devices.args                 |    61 -
>   .../pseries-many-devices.ppc64-latest.args    |    64 +
>   ...m.args => pseries-nvram.ppc64-latest.args} |     9 +-
>   ...=> pseries-panic-address.ppc64-latest.err} |     0
>   .../pseries-panic-missing.ppc64-latest.args   |    34 +
>   ...pseries-panic-no-address.ppc64-latest.args |    34 +
>   .../pseries-phb-default-missing.args          |    30 -
>   ...ies-phb-default-missing.ppc64-latest.args} |    12 +-
>   ...> pseries-phb-numa-node.ppc64-latest.args} |    16 +-
>   .../qemuxml2argvdata/pseries-phb-simple.args  |    30 -
>   ...s => pseries-phb-simple.ppc64-latest.args} |    12 +-
>   .../pseries-serial+console-native.args        |     1 -
>   ...es-serial+console-native.ppc64-latest.args |     1 +
>   .../pseries-serial-compat.args                |     1 -
>   .../pseries-serial-compat.ppc64-latest.args   |     1 +
>   ...> pseries-serial-native.ppc64-latest.args} |     9 +-
>   ...s => pseries-serial-pci.ppc64-latest.args} |     9 +-
>   ...s => pseries-serial-usb.ppc64-latest.args} |    11 +-
>   .../qemuxml2argvdata/pseries-usb-default.args |    31 -
>   .../pseries-usb-default.ppc64-latest.args     |    34 +
>   tests/qemuxml2argvdata/pseries-usb-kbd.args   |    32 -
>   .../pseries-usb-kbd.ppc64-latest.args         |    35 +
>   tests/qemuxml2argvdata/pseries-usb-multi.args |    32 -
>   .../pseries-usb-multi.ppc64-latest.args       |    35 +
>   ...eries-vio-user-assigned.ppc64-latest.args} |    19 +-
>   ...ned.args => pseries-vio.ppc64-latest.args} |    19 +-
>   tests/qemuxml2argvtest.c                      |   213 +-
>   54 files changed, 36978 insertions(+), 572 deletions(-)
>   create mode 100644 tests/domaincapsdata/qemu_7.1.0.ppc64.xml
>   create mode 100644 tests/qemucapabilitiesdata/caps_7.1.0.ppc64.replies
>   create mode 100644 tests/qemucapabilitiesdata/caps_7.1.0.ppc64.xml
>   rename tests/qemuxml2argvdata/{pseries-panic-no-address.args => pseries-basic.ppc64-latest.args} (58%)
>   delete mode 120000 tests/qemuxml2argvdata/pseries-console-native.args
>   create mode 120000 tests/qemuxml2argvdata/pseries-console-native.ppc64-latest.args
>   rename tests/qemuxml2argvdata/{pseries-console-virtio.args => pseries-console-virtio.ppc64-latest.args} (57%)
>   rename tests/qemuxml2argvdata/{pseries-cpu-compat.args => pseries-cpu-compat.ppc64-latest.args} (58%)
>   rename tests/qemuxml2argvdata/{pseries-cpu-exact.args => pseries-cpu-exact.ppc64-latest.args} (59%)
>   rename tests/qemuxml2argvdata/{pseries-cpu-le.args => pseries-cpu-le.ppc64-latest.args} (58%)
>   rename tests/qemuxml2argvdata/{pseries-default-phb-numa-node.err => pseries-default-phb-numa-node.ppc64-latest.err} (100%)
>   mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-features-ccf.xml
>   mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-features-cfpc.xml
>   mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-features-hpt-pagesize.xml
>   mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-features-htm.xml
>   mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-features-ibs.xml
>   mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-features-nested-hv.xml
>   mode change 120000 => 100644 tests/qemuxml2argvdata/pseries-features-sbbc.xml
>   rename tests/qemuxml2argvdata/{pseries-features.args => pseries-features.ppc64-latest.args} (68%)
>   create mode 100644 tests/qemuxml2argvdata/pseries-hostdevs-1.ppc64-latest.args
>   create mode 100644 tests/qemuxml2argvdata/pseries-hostdevs-2.ppc64-latest.args
>   delete mode 100644 tests/qemuxml2argvdata/pseries-hostdevs-3.args
>   create mode 100644 tests/qemuxml2argvdata/pseries-hostdevs-3.ppc64-latest.args
>   delete mode 100644 tests/qemuxml2argvdata/pseries-many-buses-1.args
>   rename tests/qemuxml2argvdata/{pseries-hostdevs-2.args => pseries-many-buses-1.ppc64-latest.args} (57%)
>   delete mode 100644 tests/qemuxml2argvdata/pseries-many-buses-2.args
>   rename tests/qemuxml2argvdata/{pseries-hostdevs-1.args => pseries-many-buses-2.ppc64-latest.args} (58%)
>   delete mode 100644 tests/qemuxml2argvdata/pseries-many-devices.args
>   create mode 100644 tests/qemuxml2argvdata/pseries-many-devices.ppc64-latest.args
>   rename tests/qemuxml2argvdata/{pseries-nvram.args => pseries-nvram.ppc64-latest.args} (63%)
>   rename tests/qemuxml2argvdata/{pseries-panic-address.err => pseries-panic-address.ppc64-latest.err} (100%)
>   create mode 100644 tests/qemuxml2argvdata/pseries-panic-missing.ppc64-latest.args
>   create mode 100644 tests/qemuxml2argvdata/pseries-panic-no-address.ppc64-latest.args
>   delete mode 100644 tests/qemuxml2argvdata/pseries-phb-default-missing.args
>   rename tests/qemuxml2argvdata/{pseries-basic.args => pseries-phb-default-missing.ppc64-latest.args} (58%)
>   rename tests/qemuxml2argvdata/{pseries-phb-numa-node.args => pseries-phb-numa-node.ppc64-latest.args} (53%)
>   delete mode 100644 tests/qemuxml2argvdata/pseries-phb-simple.args
>   rename tests/qemuxml2argvdata/{pseries-panic-missing.args => pseries-phb-simple.ppc64-latest.args} (58%)
>   delete mode 120000 tests/qemuxml2argvdata/pseries-serial+console-native.args
>   create mode 120000 tests/qemuxml2argvdata/pseries-serial+console-native.ppc64-latest.args
>   delete mode 120000 tests/qemuxml2argvdata/pseries-serial-compat.args
>   create mode 120000 tests/qemuxml2argvdata/pseries-serial-compat.ppc64-latest.args
>   rename tests/qemuxml2argvdata/{pseries-serial-native.args => pseries-serial-native.ppc64-latest.args} (61%)
>   rename tests/qemuxml2argvdata/{pseries-serial-pci.args => pseries-serial-pci.ppc64-latest.args} (60%)
>   rename tests/qemuxml2argvdata/{pseries-serial-usb.args => pseries-serial-usb.ppc64-latest.args} (57%)
>   delete mode 100644 tests/qemuxml2argvdata/pseries-usb-default.args
>   create mode 100644 tests/qemuxml2argvdata/pseries-usb-default.ppc64-latest.args
>   delete mode 100644 tests/qemuxml2argvdata/pseries-usb-kbd.args
>   create mode 100644 tests/qemuxml2argvdata/pseries-usb-kbd.ppc64-latest.args
>   delete mode 100644 tests/qemuxml2argvdata/pseries-usb-multi.args
>   create mode 100644 tests/qemuxml2argvdata/pseries-usb-multi.ppc64-latest.args
>   rename tests/qemuxml2argvdata/{pseries-vio.args => pseries-vio-user-assigned.ppc64-latest.args} (52%)
>   rename tests/qemuxml2argvdata/{pseries-vio-user-assigned.args => pseries-vio.ppc64-latest.args} (52%)
>