[v1] Fix some coding issues

[PATCH 0/3] Fix some coding issues

Jiacheng Jiang posted 3 patches 1 year, 8 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20220906134831.48490-1-jiangjiacheng@huawei.com

There is a newer version of this series

src/conf/domain_conf.c            |  4 +++-
src/remote/remote_daemon.c        |  6 +-----
src/remote/remote_daemon_config.c |  4 +---
src/remote/remote_daemon_config.h |  2 +-
src/rpc/virnetserverclient.c      | 28 ++++++++++++++--------------
5 files changed, 20 insertions(+), 24 deletions(-)

Expand all Fold all

[PATCH 0/3] Fix some coding issues

Posted by Jiacheng Jiang 1 year, 8 months ago

From: jiangjiacheng <jiangjiacheng@huawei.com>

*** BLURB HERE ***

jiangjiacheng (3):
  conf: clean up memory containing secrets before freeing
  remote: remove unnecessary return value and if branch
  Fix some coding style issues

 src/conf/domain_conf.c            |  4 +++-
 src/remote/remote_daemon.c        |  6 +-----
 src/remote/remote_daemon_config.c |  4 +---
 src/remote/remote_daemon_config.h |  2 +-
 src/rpc/virnetserverclient.c      | 28 ++++++++++++++--------------
 5 files changed, 20 insertions(+), 24 deletions(-)

-- 
2.33.0

Re: [PATCH 0/3] Fix some coding issues

Posted by Kristina Hanicova 1 year, 8 months ago

On Tue, Sep 6, 2022 at 4:14 PM Jiacheng Jiang <jiangjiacheng@huawei.com>
wrote:

> From: jiangjiacheng <jiangjiacheng@huawei.com>
>
> *** BLURB HERE ***
>
> jiangjiacheng (3):
>   conf: clean up memory containing secrets before freeing
>   remote: remove unnecessary return value and if branch
>   Fix some coding style issues
>
>  src/conf/domain_conf.c            |  4 +++-
>  src/remote/remote_daemon.c        |  6 +-----
>  src/remote/remote_daemon_config.c |  4 +---
>  src/remote/remote_daemon_config.h |  2 +-
>  src/rpc/virnetserverclient.c      | 28 ++++++++++++++--------------
>  5 files changed, 20 insertions(+), 24 deletions(-)
>



Reviewed-by: Kristina Hanicova <khanicov@redhat.com>

Kristina

Re: [PATCH 0/3] Fix some coding issues

Posted by Michal Prívozník 1 year, 7 months ago

On 9/6/22 18:26, Kristina Hanicova wrote:
> 
> 
> On Tue, Sep 6, 2022 at 4:14 PM Jiacheng Jiang <jiangjiacheng@huawei.com
> <mailto:jiangjiacheng@huawei.com>> wrote:
> 
>     From: jiangjiacheng <jiangjiacheng@huawei.com
>     <mailto:jiangjiacheng@huawei.com>>
> 
>     *** BLURB HERE ***
> 
>     jiangjiacheng (3):
>       conf: clean up memory containing secrets before freeing
>       remote: remove unnecessary return value and if branch
>       Fix some coding style issues
> 
>      src/conf/domain_conf.c            |  4 +++-
>      src/remote/remote_daemon.c        |  6 +-----
>      src/remote/remote_daemon_config.c |  4 +---
>      src/remote/remote_daemon_config.h |  2 +-
>      src/rpc/virnetserverclient.c      | 28 ++++++++++++++--------------
>      5 files changed, 20 insertions(+), 24 deletions(-)
> 
> 
> 
> 
> Reviewed-by: Kristina Hanicova <khanicov@redhat.com
> <mailto:khanicov@redhat.com>>
> 
> Kristina

Merged now.

Michal