tests: Fix qemuxml2argvtest failure on macOS 12

[libvirt PATCH 0/2] tests: Fix qemuxml2argvtest failure on macOS 12

Andrea Bolognani posted 2 patches 1 year, 8 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20220817160320.40462-1-abologna@redhat.com

src/util/vircommand.c    | 2 ++
tests/qemuxml2argvtest.c | 2 ++
2 files changed, 4 insertions(+)

Expand all Fold all

[libvirt PATCH 0/2] tests: Fix qemuxml2argvtest failure on macOS 12

Posted by Andrea Bolognani 1 year, 8 months ago

As reported in

  https://listman.redhat.com/archives/libvir-list/2022-May/230762.html

I'm still unclear on why this worked with all versions of macOS until
12, but the fix feels reasonable enough and I can't really justify
digging much further.

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/615807379
macOS 12 job:  https://gitlab.com/abologna/libvirt/-/jobs/2895958597

Andrea Bolognani (2):
  util: Preserve macOS dyld environment by default
  tests: Reset macOS dyld environment

 src/util/vircommand.c    | 2 ++
 tests/qemuxml2argvtest.c | 2 ++
 2 files changed, 4 insertions(+)

-- 
2.37.2

Re: [libvirt PATCH 0/2] tests: Fix qemuxml2argvtest failure on macOS 12

Posted by Ján Tomko 1 year, 8 months ago

On a Wednesday in 2022, Andrea Bolognani wrote:
>As reported in
>
>  https://listman.redhat.com/archives/libvir-list/2022-May/230762.html
>
>I'm still unclear on why this worked with all versions of macOS until
>12, but the fix feels reasonable enough and I can't really justify
>digging much further.
>
>Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/615807379
>macOS 12 job:  https://gitlab.com/abologna/libvirt/-/jobs/2895958597
>
>Andrea Bolognani (2):
>  util: Preserve macOS dyld environment by default
>  tests: Reset macOS dyld environment
>
> src/util/vircommand.c    | 2 ++
> tests/qemuxml2argvtest.c | 2 ++
> 2 files changed, 4 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano