Minor fixes for maxphysaddr

[libvirt] [PATCH 1/2] docs: Fix missing slashes in the maxphysaddr example

Posted by Lin Ma 3 years, 5 months ago

Signed-off-by: Lin Ma <lma@suse.com>
---
 docs/formatdomain.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index ed0d9c1959..56ca5efe43 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -1336,7 +1336,7 @@ following collection of elements. :since:`Since 0.7.5`
      <vendor>Intel</vendor>
      <topology sockets='1' dies='1' cores='2' threads='1'/>
      <cache level='3' mode='emulate'/>
-     <maxphysaddr mode='emulate' bits='42'>
+     <maxphysaddr mode='emulate' bits='42'/>
      <feature policy='disable' name='lahf_lm'/>
    </cpu>
    ...
@@ -1353,7 +1353,7 @@ following collection of elements. :since:`Since 0.7.5`
 
    <cpu mode='host-passthrough' migratable='off'>
      <cache mode='passthrough'/>
-     <maxphysaddr mode='passthrough'>
+     <maxphysaddr mode='passthrough'/>
      <feature policy='disable' name='lahf_lm'/>
    ...
 
-- 
2.26.2

Re: [libvirt] [PATCH 1/2] docs: Fix missing slashes in the maxphysaddr example

Posted by Claudio Fontana 3 years, 5 months ago

On 8/17/22 10:19, Lin Ma wrote:
> Signed-off-by: Lin Ma <lma@suse.com>
> ---
>  docs/formatdomain.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
> index ed0d9c1959..56ca5efe43 100644
> --- a/docs/formatdomain.rst
> +++ b/docs/formatdomain.rst
> @@ -1336,7 +1336,7 @@ following collection of elements. :since:`Since 0.7.5`
>       <vendor>Intel</vendor>
>       <topology sockets='1' dies='1' cores='2' threads='1'/>
>       <cache level='3' mode='emulate'/>
> -     <maxphysaddr mode='emulate' bits='42'>
> +     <maxphysaddr mode='emulate' bits='42'/>
>       <feature policy='disable' name='lahf_lm'/>
>     </cpu>
>     ...
> @@ -1353,7 +1353,7 @@ following collection of elements. :since:`Since 0.7.5`
>  
>     <cpu mode='host-passthrough' migratable='off'>
>       <cache mode='passthrough'/>
> -     <maxphysaddr mode='passthrough'>
> +     <maxphysaddr mode='passthrough'/>
>       <feature policy='disable' name='lahf_lm'/>
>     ...
>  
Reviewed-by: Claudio Fontana <cfontana@suse.de>

Re: [libvirt] [PATCH 1/2] docs: Fix missing slashes in the maxphysaddr example

Posted by Jim Fehlig 3 years, 5 months ago

On 8/17/22 02:19, Lin Ma wrote:
> Signed-off-by: Lin Ma <lma@suse.com>
> ---
>   docs/formatdomain.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Thanks for noticing the omission!

Reviewed-by: Jim Fehlig <jfehlig@suse.com>

> 
> diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
> index ed0d9c1959..56ca5efe43 100644
> --- a/docs/formatdomain.rst
> +++ b/docs/formatdomain.rst
> @@ -1336,7 +1336,7 @@ following collection of elements. :since:`Since 0.7.5`
>        <vendor>Intel</vendor>
>        <topology sockets='1' dies='1' cores='2' threads='1'/>
>        <cache level='3' mode='emulate'/>
> -     <maxphysaddr mode='emulate' bits='42'>
> +     <maxphysaddr mode='emulate' bits='42'/>
>        <feature policy='disable' name='lahf_lm'/>
>      </cpu>
>      ...
> @@ -1353,7 +1353,7 @@ following collection of elements. :since:`Since 0.7.5`
>   
>      <cpu mode='host-passthrough' migratable='off'>
>        <cache mode='passthrough'/>
> -     <maxphysaddr mode='passthrough'>
> +     <maxphysaddr mode='passthrough'/>
>        <feature policy='disable' name='lahf_lm'/>
>      ...
>