Signed-off-by: Rohit Kumar <rohit.kumar3@nutanix.com>
---
 NEWS.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/NEWS.rst b/NEWS.rst
index 9a8624a97e..9766dbe1df 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -17,6 +17,11 @@ v8.5.0 (unreleased)
 
 * **New features**
 
+  * qemu: Introduce support for network backed NVRAM
+
+    Users can now use remote store NVRAM image by specifying attribute
+    `type='network'` with `<nvram>` element.
+
   * qemu: Add support for post-copy migration recovery
 
     A new ``VIR_MIGRATE_POSTCOPY_RESUME`` flag (``virsh migrate --postcopy-resume``)
-- 
2.25.1

On 6/21/22 14:22, Rohit Kumar wrote:
> Signed-off-by: Rohit Kumar <rohit.kumar3@nutanix.com>
> ---
>  NEWS.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 

Nit pick: We like to prepend the commit subject with NEWS: so that it's
obvious this patch is only documenting recently added feature rather
than implementing the feature.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and pushed.

Michal

On 22/06/22 2:30 pm, Michal Prívozník wrote:
> On 6/21/22 14:22, Rohit Kumar wrote:
>> Signed-off-by: Rohit Kumar <rohit.kumar3@nutanix.com>
>> ---
>>   NEWS.rst | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
> Nit pick: We like to prepend the commit subject with NEWS: so that it's
> obvious this patch is only documenting recently added feature rather
> than implementing the feature.
>
> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
>
> and pushed.
>
> Michal
Yes, sure.

Thanks for reviewing this, Michal.
>

On Tue, Jun 21, 2022 at 5:53 PM Rohit Kumar <rohit.kumar3@nutanix.com> wrote:
>
> Signed-off-by: Rohit Kumar <rohit.kumar3@nutanix.com>

Reviewed-by: Ani Sinha <ani@anisinha.ca>

> ---
>  NEWS.rst | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/NEWS.rst b/NEWS.rst
> index 9a8624a97e..9766dbe1df 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -17,6 +17,11 @@ v8.5.0 (unreleased)
>
>  * **New features**
>
> +  * qemu: Introduce support for network backed NVRAM
> +
> +    Users can now use remote store NVRAM image by specifying attribute

I would say 'newly introduced attribute' so that it is clear what
already exists and what was newly introduced.

> +    `type='network'` with `<nvram>` element.
> +
>    * qemu: Add support for post-copy migration recovery
>
>      A new ``VIR_MIGRATE_POSTCOPY_RESUME`` flag (``virsh migrate --postcopy-resume``)
> --
> 2.25.1
>