It's a stable distro, so we expect all jobs to succeed.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 ci/gitlab/containers.yml | 2 +-
 ci/manifest.yml          | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/ci/gitlab/containers.yml b/ci/gitlab/containers.yml
index 5b8a91c295..37c179c439 100644
--- a/ci/gitlab/containers.yml
+++ b/ci/gitlab/containers.yml
@@ -299,7 +299,7 @@ s390x-debian-sid-container:
 
 mingw32-fedora-36-container:
   extends: .container_job
-  allow_failure: true
+  allow_failure: false
   variables:
     NAME: fedora-36-cross-mingw32
 
diff --git a/ci/manifest.yml b/ci/manifest.yml
index e85a01018e..ad0ec9a53d 100644
--- a/ci/manifest.yml
+++ b/ci/manifest.yml
@@ -157,7 +157,6 @@ targets:
       - arch: x86_64
 
       - arch: mingw32
-        allow-failure: true
         builds: false
 
       - arch: mingw64
-- 
2.35.3

On Thu, May 26, 2022 at 04:01:50PM +0200, Andrea Bolognani wrote:
> It's a stable distro, so we expect all jobs to succeed.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  ci/gitlab/containers.yml | 2 +-
>  ci/manifest.yml          | 1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/ci/gitlab/containers.yml b/ci/gitlab/containers.yml
> index 5b8a91c295..37c179c439 100644
> --- a/ci/gitlab/containers.yml
> +++ b/ci/gitlab/containers.yml
> @@ -299,7 +299,7 @@ s390x-debian-sid-container:
>  
>  mingw32-fedora-36-container:
>    extends: .container_job
> -  allow_failure: true
> +  allow_failure: false
>    variables:
>      NAME: fedora-36-cross-mingw32
>  
> diff --git a/ci/manifest.yml b/ci/manifest.yml
> index e85a01018e..ad0ec9a53d 100644
> --- a/ci/manifest.yml
> +++ b/ci/manifest.yml
> @@ -157,7 +157,6 @@ targets:
>        - arch: x86_64
>  
>        - arch: mingw32
> -        allow-failure: true

There must be a hysterical raisin for this (not that I object to the patch),
maybe there was a bug in mingw toolchain giving us a hard time? I don't think
it has anything to do with the given OS's stability as the commit message
suggest, but if you don't remember and don't feel like digging, sure you can
keep the commit message as is.

Reviewed-by: Erik Skultety <eskultet@redhat.com>

On Thu, May 26, 2022 at 04:23:44PM +0200, Erik Skultety wrote:
> On Thu, May 26, 2022 at 04:01:50PM +0200, Andrea Bolognani wrote:
> > +++ b/ci/manifest.yml
> > @@ -157,7 +157,6 @@ targets:
> >        - arch: x86_64
> >
> >        - arch: mingw32
> > -        allow-failure: true
>
> There must be a hysterical raisin for this (not that I object to the patch),
> maybe there was a bug in mingw toolchain giving us a hard time? I don't think
> it has anything to do with the given OS's stability as the commit message
> suggest, but if you don't remember and don't feel like digging, sure you can
> keep the commit message as is.

I think it was simply carried over by mistake when the MinGW jobs
were added to stable Fedora after only having been executed on
Rawhide (where 'allow-failure: true' makes perfect sense) up until
that point.

The relevant commit is

  commit c7edcb320be3ae6cfa3230f4d3b2c867db49a613
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   Tue Nov 23 12:12:25 2021 +0000

    ci: run a mingw64 job on stable Fedora

    Both of the current mingw jobs are marked as 'allow_failure' because
    they are running against Fedora rawhide which is an unstable distro.

    We need at least one mingw job to be gating to more reliably detect
    problems.

    This introduces dockerfiles for both mingw variants on Fedora 35
    and sets the mingw64 build to run on Fedora 34, and mingw32 on
    Fedora rawhide.

    Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
    Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization