Changes from [v1]:

  * most patches have been pushed;
  * reduce quoting for most users by only using it when it's
    actually necessary to do so.

[v1] https://listman.redhat.com/archives/libvir-list/2022-February/msg00477.html

Andrea Bolognani (6):
  virnetclient: Improve spacing of ssh script
  virnetclient: Use 'if' consistently
  virnetclient: Handle netcatPath presence all at once
  virnetclient: Don't unnecessarily quote user-provided values
  virnetsockettest: Test more socket paths
  virnetclient: Escape socket path

 src/rpc/virnetclient.c   | 78 +++++++++++++++++++------------
 tests/virnetsockettest.c | 99 ++++++++++++++++++++--------------------
 2 files changed, 99 insertions(+), 78 deletions(-)

-- 
2.35.1

On Mon, Feb 14, 2022 at 05:03:29PM +0100, Andrea Bolognani wrote:
> Changes from [v1]:
> 
>   * most patches have been pushed;
>   * reduce quoting for most users by only using it when it's
>     actually necessary to do so.

This still has the back compatibility problems I mentioned
previously and has introduced a further one by reducing
quoting. I'm not in favour of knowingly introducing back
compatibility problems when it doesn't solve functional
problems on the libvirt side.

If we want to support whitespace in the socket path, it
is possible todo that in a back compatible manner, by only
changing our quoting of the socket path when we know it has
whitespace, and not touching anything else.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|