[v5] Automatic mutex management

[libvirt PATCH v5 6/9] virChrdevFDStreamCloseCb: Use virLockGuardLock

Posted by Tim Wiederhake 4 years ago

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
---
 src/conf/virchrdev.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/conf/virchrdev.c b/src/conf/virchrdev.c
index b5477b03d5..c9b2134e3b 100644
--- a/src/conf/virchrdev.c
+++ b/src/conf/virchrdev.c
@@ -237,12 +237,10 @@ static void virChrdevFDStreamCloseCb(virStreamPtr st G_GNUC_UNUSED,
                                       void *opaque)
 {
     virChrdevStreamInfo *priv = opaque;
-    virMutexLock(&priv->devs->lock);
+    VIR_LOCK_GUARD lock = virLockGuardLock(&priv->devs->lock);
 
     /* remove entry from hash */
     virHashRemoveEntry(priv->devs->hash, priv->path);
-
-    virMutexUnlock(&priv->devs->lock);
 }
 
 /**
-- 
2.31.1

Re: [libvirt PATCH v5 6/9] virChrdevFDStreamCloseCb: Use virLockGuardLock

Posted by Daniel P. Berrangé 4 years ago

On Tue, Feb 01, 2022 at 02:20:14PM +0100, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
> ---
>  src/conf/virchrdev.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|