[PATCH v2 03/29] qemu_domain: turn qemuDomainMachineIsPSeries() static

Daniel Henrique Barboza posted 29 patches 4 years ago
There is a newer version of this series
[PATCH v2 03/29] qemu_domain: turn qemuDomainMachineIsPSeries() static
Posted by Daniel Henrique Barboza 4 years ago
The function is now unused outside of qemu_domain.c.

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
 src/qemu/qemu_domain.c | 2 +-
 src/qemu/qemu_domain.h | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 2e21a95f38..98a6a2657d 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -8631,7 +8631,7 @@ qemuDomainMachineIsRISCVVirt(const char *machine,
 
 /* You should normally avoid this function and use
  * qemuDomainIsPSeries() instead. */
-bool
+static bool
 qemuDomainMachineIsPSeries(const char *machine,
                            const virArch arch)
 {
diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
index d07a279a1b..fe4420bf83 100644
--- a/src/qemu/qemu_domain.h
+++ b/src/qemu/qemu_domain.h
@@ -759,8 +759,6 @@ virDomainChrDef *qemuFindAgentConfig(virDomainDef *def);
  * doesn't have "Machine" in the name instead. */
 bool qemuDomainMachineIsARMVirt(const char *machine,
                                 const virArch arch);
-bool qemuDomainMachineIsPSeries(const char *machine,
-                                const virArch arch);
 bool qemuDomainMachineIsPowerPC(const char *machine,
                                 const virArch arch);
 bool qemuDomainMachineHasBuiltinIDE(const char *machine,
-- 
2.34.1

Re: [PATCH v2 03/29] qemu_domain: turn qemuDomainMachineIsPSeries() static
Posted by Ján Tomko 3 years, 11 months ago
On a Tuesday in 2022, Daniel Henrique Barboza wrote:
>The function is now unused outside of qemu_domain.c.
>
>Reviewed-by: Peter Krempa <pkrempa@redhat.com>
>Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
>---
> src/qemu/qemu_domain.c | 2 +-
> src/qemu/qemu_domain.h | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano