[v1] ppc64 PowerNV machines support

[PATCH 04/33] qemu_validate.c: use qemuDomainIsPowerPC() in qemuValidateDomainChrDef()

Posted by Daniel Henrique Barboza 4 years ago

Both PowerNV and pSeries machines don't support parallel ports.

Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
 src/qemu/qemu_validate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index ae0ee4e744..da41848761 100644
--- a/src/qemu/qemu_validate.c
+++ b/src/qemu/qemu_validate.c
@@ -2007,7 +2007,7 @@ qemuValidateDomainChrDef(const virDomainChrDef *dev,
         return -1;
 
     if (dev->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_PARALLEL &&
-        (ARCH_IS_S390(def->os.arch) || qemuDomainIsPSeries(def))) {
+        (ARCH_IS_S390(def->os.arch) || qemuDomainIsPowerPC(def))) {
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                            _("parallel ports are not supported"));
             return -1;
-- 
2.34.1

Re: [PATCH 04/33] qemu_validate.c: use qemuDomainIsPowerPC() in qemuValidateDomainChrDef()

Posted by Peter Krempa 4 years ago

On Thu, Jan 20, 2022 at 10:52:07 -0300, Daniel Henrique Barboza wrote:
> Both PowerNV and pSeries machines don't support parallel ports.
> 
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> ---
>  src/qemu/qemu_validate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>