[libvirt PATCH v3 0/2] Code style documentation

Tim Wiederhake posted 2 patches 2 years, 3 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20220119100654.14973-1-twiederh@redhat.com
docs/coding-style.rst | 28 +++++++++++++++++++++++-----
1 file changed, 23 insertions(+), 5 deletions(-)
[libvirt PATCH v3 0/2] Code style documentation
Posted by Tim Wiederhake 2 years, 3 months ago
Some additions and clarifications to libvirt's code style
documentation, based on points of feedback that are given
regularly on the mailing list.

V1: https://listman.redhat.com/archives/libvir-list/2022-January/msg00631.html
V2: https://listman.redhat.com/archives/libvir-list/2022-January/msg00681.html

Changes since V2:
* Changed the example type name in patch 1

Tim Wiederhake (2):
  docs: coding-style: Clarify on virXXXPtr types
  docs: coding-style: One variable declaration per line

 docs/coding-style.rst | 28 +++++++++++++++++++++++-----
 1 file changed, 23 insertions(+), 5 deletions(-)

-- 
2.31.1


Re: [libvirt PATCH v3 0/2] Code style documentation
Posted by Andrea Bolognani 2 years, 3 months ago
On Wed, Jan 19, 2022 at 11:06:52AM +0100, Tim Wiederhake wrote:
> Some additions and clarifications to libvirt's code style
> documentation, based on points of feedback that are given
> regularly on the mailing list.
>
> V1: https://listman.redhat.com/archives/libvir-list/2022-January/msg00631.html
> V2: https://listman.redhat.com/archives/libvir-list/2022-January/msg00681.html
>
> Changes since V2:
> * Changed the example type name in patch 1
>
> Tim Wiederhake (2):
>   docs: coding-style: Clarify on virXXXPtr types
>   docs: coding-style: One variable declaration per line

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt PATCH v3 0/2] Code style documentation
Posted by Pavel Hrdina 2 years, 3 months ago
On Wed, Jan 19, 2022 at 11:06:52AM +0100, Tim Wiederhake wrote:
> Some additions and clarifications to libvirt's code style
> documentation, based on points of feedback that are given
> regularly on the mailing list.
> 
> V1: https://listman.redhat.com/archives/libvir-list/2022-January/msg00631.html
> V2: https://listman.redhat.com/archives/libvir-list/2022-January/msg00681.html
> 
> Changes since V2:
> * Changed the example type name in patch 1
> 
> Tim Wiederhake (2):
>   docs: coding-style: Clarify on virXXXPtr types
>   docs: coding-style: One variable declaration per line

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Re: [libvirt PATCH v3 0/2] Code style documentation
Posted by Ján Tomko 2 years, 3 months ago
On a Wednesday in 2022, Tim Wiederhake wrote:
>Some additions and clarifications to libvirt's code style
>documentation, based on points of feedback that are given
>regularly on the mailing list.
>
>V1: https://listman.redhat.com/archives/libvir-list/2022-January/msg00631.html
>V2: https://listman.redhat.com/archives/libvir-list/2022-January/msg00681.html
>
>Changes since V2:
>* Changed the example type name in patch 1
>
>Tim Wiederhake (2):
>  docs: coding-style: Clarify on virXXXPtr types
>  docs: coding-style: One variable declaration per line
>
> docs/coding-style.rst | 28 +++++++++++++++++++++++-----
> 1 file changed, 23 insertions(+), 5 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
Re: [libvirt PATCH v3 0/2] Code style documentation
Posted by Peter Krempa 2 years, 3 months ago
On Wed, Jan 19, 2022 at 11:06:52 +0100, Tim Wiederhake wrote:
> Some additions and clarifications to libvirt's code style
> documentation, based on points of feedback that are given
> regularly on the mailing list.
> 
> V1: https://listman.redhat.com/archives/libvir-list/2022-January/msg00631.html
> V2: https://listman.redhat.com/archives/libvir-list/2022-January/msg00681.html
> 
> Changes since V2:
> * Changed the example type name in patch 1
> 
> Tim Wiederhake (2):
>   docs: coding-style: Clarify on virXXXPtr types
>   docs: coding-style: One variable declaration per line

Reviewed-by: Peter Krempa <pkrempa@redhat.com>

Re: [libvirt PATCH v3 0/2] Code style documentation
Posted by Michal Prívozník 2 years, 3 months ago
On 1/19/22 11:06, Tim Wiederhake wrote:
> Some additions and clarifications to libvirt's code style
> documentation, based on points of feedback that are given
> regularly on the mailing list.
> 
> V1: https://listman.redhat.com/archives/libvir-list/2022-January/msg00631.html
> V2: https://listman.redhat.com/archives/libvir-list/2022-January/msg00681.html
> 
> Changes since V2:
> * Changed the example type name in patch 1
> 
> Tim Wiederhake (2):
>   docs: coding-style: Clarify on virXXXPtr types
>   docs: coding-style: One variable declaration per line
> 
>  docs/coding-style.rst | 28 +++++++++++++++++++++++-----
>  1 file changed, 23 insertions(+), 5 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal