Some additions and clarifications to libvirt's code style documentation, based on points of feedback that are given regularly on the mailing list. V1: https://listman.redhat.com/archives/libvir-list/2022-January/msg00631.html V2: https://listman.redhat.com/archives/libvir-list/2022-January/msg00681.html Changes since V2: * Changed the example type name in patch 1 Tim Wiederhake (2): docs: coding-style: Clarify on virXXXPtr types docs: coding-style: One variable declaration per line docs/coding-style.rst | 28 +++++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) -- 2.31.1
On Wed, Jan 19, 2022 at 11:06:52AM +0100, Tim Wiederhake wrote: > Some additions and clarifications to libvirt's code style > documentation, based on points of feedback that are given > regularly on the mailing list. > > V1: https://listman.redhat.com/archives/libvir-list/2022-January/msg00631.html > V2: https://listman.redhat.com/archives/libvir-list/2022-January/msg00681.html > > Changes since V2: > * Changed the example type name in patch 1 > > Tim Wiederhake (2): > docs: coding-style: Clarify on virXXXPtr types > docs: coding-style: One variable declaration per line Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization
On Wed, Jan 19, 2022 at 11:06:52AM +0100, Tim Wiederhake wrote: > Some additions and clarifications to libvirt's code style > documentation, based on points of feedback that are given > regularly on the mailing list. > > V1: https://listman.redhat.com/archives/libvir-list/2022-January/msg00631.html > V2: https://listman.redhat.com/archives/libvir-list/2022-January/msg00681.html > > Changes since V2: > * Changed the example type name in patch 1 > > Tim Wiederhake (2): > docs: coding-style: Clarify on virXXXPtr types > docs: coding-style: One variable declaration per line Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
On a Wednesday in 2022, Tim Wiederhake wrote: >Some additions and clarifications to libvirt's code style >documentation, based on points of feedback that are given >regularly on the mailing list. > >V1: https://listman.redhat.com/archives/libvir-list/2022-January/msg00631.html >V2: https://listman.redhat.com/archives/libvir-list/2022-January/msg00681.html > >Changes since V2: >* Changed the example type name in patch 1 > >Tim Wiederhake (2): > docs: coding-style: Clarify on virXXXPtr types > docs: coding-style: One variable declaration per line > > docs/coding-style.rst | 28 +++++++++++++++++++++++----- > 1 file changed, 23 insertions(+), 5 deletions(-) > Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano
On Wed, Jan 19, 2022 at 11:06:52 +0100, Tim Wiederhake wrote: > Some additions and clarifications to libvirt's code style > documentation, based on points of feedback that are given > regularly on the mailing list. > > V1: https://listman.redhat.com/archives/libvir-list/2022-January/msg00631.html > V2: https://listman.redhat.com/archives/libvir-list/2022-January/msg00681.html > > Changes since V2: > * Changed the example type name in patch 1 > > Tim Wiederhake (2): > docs: coding-style: Clarify on virXXXPtr types > docs: coding-style: One variable declaration per line Reviewed-by: Peter Krempa <pkrempa@redhat.com>
On 1/19/22 11:06, Tim Wiederhake wrote: > Some additions and clarifications to libvirt's code style > documentation, based on points of feedback that are given > regularly on the mailing list. > > V1: https://listman.redhat.com/archives/libvir-list/2022-January/msg00631.html > V2: https://listman.redhat.com/archives/libvir-list/2022-January/msg00681.html > > Changes since V2: > * Changed the example type name in patch 1 > > Tim Wiederhake (2): > docs: coding-style: Clarify on virXXXPtr types > docs: coding-style: One variable declaration per line > > docs/coding-style.rst | 28 +++++++++++++++++++++++----- > 1 file changed, 23 insertions(+), 5 deletions(-) > Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Michal
© 2016 - 2024 Red Hat, Inc.