[PATCH V2 0/2] docs: Add man page for libvirt-guests

Jim Fehlig posted 2 patches 2 weeks ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20220110212401.31422-1-jfehlig@suse.com
docs/manpages/index.rst          |   1 +
docs/manpages/libvirt-guests.rst | 151 +++++++++++++++++++++++++++++++
docs/manpages/meson.build        |   1 +
libvirt.spec.in                  |   1 +
tools/libvirt-guests.service.in  |   2 +-
tools/meson.build                |  38 ++++----
6 files changed, 175 insertions(+), 19 deletions(-)
create mode 100644 docs/manpages/libvirt-guests.rst

[PATCH V2 0/2] docs: Add man page for libvirt-guests

Posted by Jim Fehlig 2 weeks ago
V2 of https://listman.redhat.com/archives/libvir-list/2022-January/msg00336.html

Changes since V1:
- New patch to only install libvirt-guests when building libvirtd
- Only install libvirt-guests man page when building libvirtd
- Default config overridden in sysconfig file, not environment

Jim Fehlig (2):
  build: Only install libvirt-guests when building libvirtd
  docs: Add man page for libvirt-guests

 docs/manpages/index.rst          |   1 +
 docs/manpages/libvirt-guests.rst | 151 +++++++++++++++++++++++++++++++
 docs/manpages/meson.build        |   1 +
 libvirt.spec.in                  |   1 +
 tools/libvirt-guests.service.in  |   2 +-
 tools/meson.build                |  38 ++++----
 6 files changed, 175 insertions(+), 19 deletions(-)
 create mode 100644 docs/manpages/libvirt-guests.rst

-- 
2.34.1


Re: [PATCH V2 0/2] docs: Add man page for libvirt-guests

Posted by Andrea Bolognani 1 week, 6 days ago
On Mon, Jan 10, 2022 at 02:23:59PM -0700, Jim Fehlig wrote:
> V2 of https://listman.redhat.com/archives/libvir-list/2022-January/msg00336.html
>
> Changes since V1:
> - New patch to only install libvirt-guests when building libvirtd
> - Only install libvirt-guests man page when building libvirtd
> - Default config overridden in sysconfig file, not environment
>
> Jim Fehlig (2):
>   build: Only install libvirt-guests when building libvirtd
>   docs: Add man page for libvirt-guests
>
>  docs/manpages/index.rst          |   1 +
>  docs/manpages/libvirt-guests.rst | 151 +++++++++++++++++++++++++++++++
>  docs/manpages/meson.build        |   1 +
>  libvirt.spec.in                  |   1 +
>  tools/libvirt-guests.service.in  |   2 +-
>  tools/meson.build                |  38 ++++----
>  6 files changed, 175 insertions(+), 19 deletions(-)
>  create mode 100644 docs/manpages/libvirt-guests.rst

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH V2 0/2] docs: Add man page for libvirt-guests

Posted by Jim Fehlig 1 week, 6 days ago
On 1/11/22 09:00, Andrea Bolognani wrote:
> On Mon, Jan 10, 2022 at 02:23:59PM -0700, Jim Fehlig wrote:
>> V2 of https://listman.redhat.com/archives/libvir-list/2022-January/msg00336.html
>>
>> Changes since V1:
>> - New patch to only install libvirt-guests when building libvirtd
>> - Only install libvirt-guests man page when building libvirtd
>> - Default config overridden in sysconfig file, not environment
>>
>> Jim Fehlig (2):
>>    build: Only install libvirt-guests when building libvirtd
>>    docs: Add man page for libvirt-guests
>>
>>   docs/manpages/index.rst          |   1 +
>>   docs/manpages/libvirt-guests.rst | 151 +++++++++++++++++++++++++++++++
>>   docs/manpages/meson.build        |   1 +
>>   libvirt.spec.in                  |   1 +
>>   tools/libvirt-guests.service.in  |   2 +-
>>   tools/meson.build                |  38 ++++----
>>   6 files changed, 175 insertions(+), 19 deletions(-)
>>   create mode 100644 docs/manpages/libvirt-guests.rst
> 
> Reviewed-by: Andrea Bolognani <abologna@redhat.com>

Thanks. I suppose the build changes are enough to postpone pushing these patches 
until after the release on Friday.

Regards,
Jim

Re: [PATCH V2 0/2] docs: Add man page for libvirt-guests

Posted by Andrea Bolognani 1 week ago
On Tue, Jan 11, 2022 at 10:58:08AM -0700, Jim Fehlig wrote:
> On 1/11/22 09:00, Andrea Bolognani wrote:
> > On Mon, Jan 10, 2022 at 02:23:59PM -0700, Jim Fehlig wrote:
> > > Jim Fehlig (2):
> > >    build: Only install libvirt-guests when building libvirtd
> > >    docs: Add man page for libvirt-guests
> >
> > Reviewed-by: Andrea Bolognani <abologna@redhat.com>
>
> Thanks. I suppose the build changes are enough to postpone pushing these
> patches until after the release on Friday.

I've pushed them now.

-- 
Andrea Bolognani / Red Hat / Virtualization