style issues in docs/ and libvirt.spec.in (abologna)
rebased to 4b77b194069f048e6efdaf5d363098ae039dc4f5

Olaf Hering (2):
  remove sysconfig files
  NEWS: mention removal of sysconfig

 NEWS.rst                                | 10 ++++
 docs/daemons.rst                        | 21 ++++++++
 docs/remote.html.in                     |  6 +--
 libvirt.spec.in                         | 69 +++++++++++++++++++------
 src/ch/meson.build                      |  5 --
 src/ch/virtchd.service.in               |  1 +
 src/ch/virtchd.sysconf                  |  3 --
 src/interface/meson.build               |  5 --
 src/interface/virtinterfaced.service.in |  1 +
 src/interface/virtinterfaced.sysconf    |  3 --
 src/libxl/meson.build                   |  5 --
 src/libxl/virtxend.service.in           |  1 +
 src/libxl/virtxend.sysconf              |  3 --
 src/locking/meson.build                 |  5 --
 src/locking/virtlockd.service.in        |  1 +
 src/locking/virtlockd.sysconf           |  3 --
 src/logging/meson.build                 |  5 --
 src/logging/virtlogd.sysconf            |  3 --
 src/lxc/meson.build                     |  5 --
 src/lxc/virtlxcd.service.in             |  1 +
 src/lxc/virtlxcd.sysconf                |  3 --
 src/meson.build                         | 16 ------
 src/network/meson.build                 |  5 --
 src/network/virtnetworkd.service.in     |  1 +
 src/network/virtnetworkd.sysconf        |  3 --
 src/node_device/meson.build             |  5 --
 src/node_device/virtnodedevd.service.in |  1 +
 src/node_device/virtnodedevd.sysconf    |  3 --
 src/nwfilter/meson.build                |  5 --
 src/nwfilter/virtnwfilterd.service.in   |  1 +
 src/nwfilter/virtnwfilterd.sysconf      |  3 --
 src/qemu/meson.build                    |  5 --
 src/qemu/virtqemud.service.in           |  7 +++
 src/qemu/virtqemud.sysconf              | 12 -----
 src/remote/libvirtd.service.in          |  7 +++
 src/remote/libvirtd.sysconf             | 21 --------
 src/remote/meson.build                  | 10 ----
 src/remote/virtproxyd.service.in        |  1 +
 src/remote/virtproxyd.sysconf           |  3 --
 src/secret/meson.build                  |  5 --
 src/secret/virtsecretd.service.in       |  1 +
 src/secret/virtsecretd.sysconf          |  3 --
 src/storage/meson.build                 |  5 --
 src/storage/virtstoraged.service.in     |  1 +
 src/storage/virtstoraged.sysconf        |  3 --
 src/vbox/meson.build                    |  5 --
 src/vbox/virtvboxd.service.in           |  1 +
 src/vbox/virtvboxd.sysconf              |  3 --
 src/vz/meson.build                      |  5 --
 src/vz/virtvzd.service.in               |  1 +
 src/vz/virtvzd.sysconf                  |  3 --
 tools/libvirt-guests.sh.in              | 40 ++++++++++++++
 tools/libvirt-guests.sysconf            | 50 ------------------
 tools/meson.build                       |  6 ---
 54 files changed, 155 insertions(+), 245 deletions(-)
 delete mode 100644 src/ch/virtchd.sysconf
 delete mode 100644 src/interface/virtinterfaced.sysconf
 delete mode 100644 src/libxl/virtxend.sysconf
 delete mode 100644 src/locking/virtlockd.sysconf
 delete mode 100644 src/logging/virtlogd.sysconf
 delete mode 100644 src/lxc/virtlxcd.sysconf
 delete mode 100644 src/network/virtnetworkd.sysconf
 delete mode 100644 src/node_device/virtnodedevd.sysconf
 delete mode 100644 src/nwfilter/virtnwfilterd.sysconf
 delete mode 100644 src/qemu/virtqemud.sysconf
 delete mode 100644 src/remote/libvirtd.sysconf
 delete mode 100644 src/remote/virtproxyd.sysconf
 delete mode 100644 src/secret/virtsecretd.sysconf
 delete mode 100644 src/storage/virtstoraged.sysconf
 delete mode 100644 src/vbox/virtvboxd.sysconf
 delete mode 100644 src/vz/virtvzd.sysconf
 delete mode 100644 tools/libvirt-guests.sysconf

On 1/3/22 03:49, Olaf Hering wrote:
> style issues in docs/ and libvirt.spec.in (abologna)
> rebased to 4b77b194069f048e6efdaf5d363098ae039dc4f5

Hi Andrea,

Thanks for reviewing v6! It looks like Olaf has addressed all of your comments. 
Any additional issues with this version? Any reservations with pushing before 
the 8.0.0 freeze?

Regards,
Jim

On Wed, Jan 05, 2022 at 12:13:28PM -0700, Jim Fehlig wrote:
> On 1/3/22 03:49, Olaf Hering wrote:
> > style issues in docs/ and libvirt.spec.in (abologna)
>
> Hi Andrea,
>
> Thanks for reviewing v6! It looks like Olaf has addressed all of your
> comments. Any additional issues with this version?

The concerns mentioned here have not been addressed:

  https://listman.redhat.com/archives/libvir-list/2022-January/msg00021.html

I don't plan to give the patch my R-b until they have.

-- 
Andrea Bolognani / Red Hat / Virtualization

On 1/7/22 09:55, Andrea Bolognani wrote:
> On Wed, Jan 05, 2022 at 12:13:28PM -0700, Jim Fehlig wrote:
>> On 1/3/22 03:49, Olaf Hering wrote:
>>> style issues in docs/ and libvirt.spec.in (abologna)
>>
>> Hi Andrea,
>>
>> Thanks for reviewing v6! It looks like Olaf has addressed all of your
>> comments. Any additional issues with this version?
> 
> The concerns mentioned here have not been addressed:
> 
>    https://listman.redhat.com/archives/libvir-list/2022-January/msg00021.html

I looked at that thread again and want to verify what is missing. IIUC, you 
agreed the '--listen' comment is not needed in the service file since it is well 
documented in the manpage, etc.

WRT libvirt-guests, Olaf added the comments for each env setting to the top of 
the script. I guess what is missing is your request for a comment in the service 
file telling where to look? I.e. the following part?

[Service]
# To learn what configuration knobs are available for this
# service, check out the top of the libvirt-guest.sh script
...

Regards,
Jim

On Fri, Jan 07, 2022 at 11:20:54AM -0700, Jim Fehlig wrote:
> On 1/7/22 09:55, Andrea Bolognani wrote:
> > The concerns mentioned here have not been addressed:
> >
> >    https://listman.redhat.com/archives/libvir-list/2022-January/msg00021.html
>
> I looked at that thread again and want to verify what is missing. IIUC, you
> agreed the '--listen' comment is not needed in the service file since it is
> well documented in the manpage, etc.

Yes.

> WRT libvirt-guests, Olaf added the comments for each env setting to the top
> of the script. I guess what is missing is your request for a comment in the
> service file telling where to look? I.e. the following part?
>
> [Service]
> # To learn what configuration knobs are available for this
> # service, check out the top of the libvirt-guest.sh script
> ...

That's the main part, yes. I also suggested that the configuration
bits be moved to the very top of the libvirt-guest.sh script, right
after the license blurb, so that they're more visible, but that's not
quite as important as having a well-documented path from the service
file, where settings have to be applied, to the script, which is the
only source of documentation for them.

-- 
Andrea Bolognani / Red Hat / Virtualization

Wed, 5 Jan 2022 12:13:28 -0700 Jim Fehlig <jfehlig@suse.com>:

> Thanks for reviewing v6! It looks like Olaf has addressed all of your comments. 

I plan to provide a man page for libvirt-guests, just did not get around to actually write it down.


Olaf

On 1/7/22 12:17, Olaf Hering wrote:
> Wed, 5 Jan 2022 12:13:28 -0700 Jim Fehlig <jfehlig@suse.com>:
> 
>> Thanks for reviewing v6! It looks like Olaf has addressed all of your comments.
> 
> I plan to provide a man page for libvirt-guests, just did not get around to actually write it down.

In retribution for missing Andrea's review comments, I've sent a V1 of the man page

https://listman.redhat.com/archives/libvir-list/2022-January/msg00336.html

Jim