spec: Drop BuildRequires on ZFS

[libvirt PATCH] spec: Drop BuildRequires on ZFS

Andrea Bolognani posted 1 patch 2 years, 3 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20211228160052.58834-1-abologna@redhat.com

libvirt.spec.in | 6 ------
1 file changed, 6 deletions(-)

Expand all Fold all

[libvirt PATCH] spec: Drop BuildRequires on ZFS

Posted by Andrea Bolognani 2 years, 3 months ago

We're no longer performing build time detection.

Fixes: 506c3a39d6e645c8414c278ceaba97935f90cb95
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 libvirt.spec.in | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 7bd74da2c9..9e24ba92ff 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -320,12 +320,6 @@ BuildRequires: glusterfs-devel >= 3.4.1
 %if %{with_storage_sheepdog}
 BuildRequires: sheepdog
 %endif
-%if %{with_storage_zfs}
-# Support any conforming implementation of zfs. On stock Fedora
-# this is zfs-fuse, but could be zfsonlinux upstream RPMs
-BuildRequires: /sbin/zfs
-BuildRequires: /sbin/zpool
-%endif
 %if %{with_numactl}
 # For QEMU/LXC numa info
 BuildRequires: numactl-devel
-- 
2.31.1

Re: [libvirt PATCH] spec: Drop BuildRequires on ZFS

Posted by Martin Kletzander 2 years, 3 months ago

On Tue, Dec 28, 2021 at 05:00:52PM +0100, Andrea Bolognani wrote:
>We're no longer performing build time detection.
>
>Fixes: 506c3a39d6e645c8414c278ceaba97935f90cb95
>Signed-off-by: Andrea Bolognani <abologna@redhat.com>

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

>---
> libvirt.spec.in | 6 ------
> 1 file changed, 6 deletions(-)
>
>diff --git a/libvirt.spec.in b/libvirt.spec.in
>index 7bd74da2c9..9e24ba92ff 100644
>--- a/libvirt.spec.in
>+++ b/libvirt.spec.in
>@@ -320,12 +320,6 @@ BuildRequires: glusterfs-devel >= 3.4.1
> %if %{with_storage_sheepdog}
> BuildRequires: sheepdog
> %endif
>-%if %{with_storage_zfs}
>-# Support any conforming implementation of zfs. On stock Fedora
>-# this is zfs-fuse, but could be zfsonlinux upstream RPMs
>-BuildRequires: /sbin/zfs
>-BuildRequires: /sbin/zpool
>-%endif
> %if %{with_numactl}
> # For QEMU/LXC numa info
> BuildRequires: numactl-devel
>-- 
>2.31.1
>