V2 of https://listman.redhat.com/archives/libvir-list/2021-November/msg00980.html

Like V1, this series is compile-tested only. I plan to work on functional
testing soon, after wrapping up some tasks.

Changes since V1:
- Optional secret set address changed to unsigned long long
- Improved documentation
- Ensure VM is in paused state
- Other small fixes

Jim Fehlig (3):
  libvirt: Introduce virDomainSetLaunchSecurityState public API
  remote: Add RPC support for the virDomainSetLaunchSecurityState API
  qemu: Implement the virDomainSetLaunchSecurityState API

 include/libvirt/libvirt-domain.h | 35 +++++++++++++
 src/driver-hypervisor.h          |  7 +++
 src/libvirt-domain.c             | 62 ++++++++++++++++++++++
 src/libvirt_public.syms          |  5 ++
 src/qemu/qemu_driver.c           | 88 ++++++++++++++++++++++++++++++++
 src/qemu/qemu_monitor.c          | 14 +++++
 src/qemu/qemu_monitor.h          |  7 +++
 src/qemu/qemu_monitor_json.c     | 45 ++++++++++++++++
 src/qemu/qemu_monitor_json.h     |  6 +++
 src/remote/remote_driver.c       |  1 +
 src/remote/remote_protocol.x     | 17 +++++-
 src/remote_protocol-structs      |  9 ++++
 12 files changed, 295 insertions(+), 1 deletion(-)

-- 
2.34.1

On Thu, Dec 09, 2021 at 15:04:12 -0700, Jim Fehlig wrote:
> V2 of https://listman.redhat.com/archives/libvir-list/2021-November/msg00980.html
> 
> Like V1, this series is compile-tested only. I plan to work on functional
> testing soon, after wrapping up some tasks.

I have 2 minor comments:

- virsh impl is missing and it's not justified why
- 'qemuMonitorJSONSetLaunchSecurityState' is missing a test case in
  qemumonitorjsontest. A simple test with GEN_TEST_FUNC/DO_TEST_GEN is
  enough, it validates the arguments against the QMP monitor schema.

On Fri, Dec 10, 2021 at 09:48:00AM +0100, Peter Krempa wrote:
> On Thu, Dec 09, 2021 at 15:04:12 -0700, Jim Fehlig wrote:
> > V2 of https://listman.redhat.com/archives/libvir-list/2021-November/msg00980.html
> > 
> > Like V1, this series is compile-tested only. I plan to work on functional
> > testing soon, after wrapping up some tasks.
> 
> I have 2 minor comments:
> 
> - virsh impl is missing and it's not justified why

virsh is missing for all the sev related commands, but I've just
addressed that in my series, so agree it makes sense to add in
this series too.

> - 'qemuMonitorJSONSetLaunchSecurityState' is missing a test case in
>   qemumonitorjsontest. A simple test with GEN_TEST_FUNC/DO_TEST_GEN is
>   enough, it validates the arguments against the QMP monitor schema.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|