[v1] cgroup and thread management in ch driver.

[libvirt PATCH 02/13] ch: Explicitly link to virt_util_lib

Posted by Praveen K Paladugu 4 years, 3 months ago

From: Vineeth Pillai <viremana@linux.microsoft.com>

link to virt_util_lib while building ch driver.

Signed-off-by: Vineeth Pillai <viremana@linux.microsoft.com>
Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
---
 src/ch/meson.build | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/ch/meson.build b/src/ch/meson.build
index e34974d56c..5c6cab2a9f 100644
--- a/src/ch/meson.build
+++ b/src/ch/meson.build
@@ -30,6 +30,9 @@ if conf.has('WITH_CH')
     include_directories: [
       conf_inc_dir,
     ],
+    link_with: [
+      virt_util_lib,
+    ]
   )
 
   virt_modules += {
-- 
2.27.0

Re: [libvirt PATCH 02/13] ch: Explicitly link to virt_util_lib

Posted by Michal Prívozník 4 years, 3 months ago

On 10/22/21 5:37 PM, Praveen K Paladugu wrote:
> From: Vineeth Pillai <viremana@linux.microsoft.com>
> 
> link to virt_util_lib while building ch driver.
> 
> Signed-off-by: Vineeth Pillai <viremana@linux.microsoft.com>
> Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
> ---
>  src/ch/meson.build | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/ch/meson.build b/src/ch/meson.build
> index e34974d56c..5c6cab2a9f 100644
> --- a/src/ch/meson.build
> +++ b/src/ch/meson.build
> @@ -30,6 +30,9 @@ if conf.has('WITH_CH')
>      include_directories: [
>        conf_inc_dir,
>      ],
> +    link_with: [
> +      virt_util_lib,
> +    ]
>    )
>  
>    virt_modules += {
> 

IIUC this is only needed because of missing libvirt_private.syms change
(pointed out in 1/13). After the suggested change is done this patch
shouldn't be needed.

Michal