[PATCH 1/2] qemu: move temp file of screenshot and memorypeek to autoDumpPath

Peng Liang posted 2 patches 4 years, 5 months ago
There is a newer version of this series
[PATCH 1/2] qemu: move temp file of screenshot and memorypeek to autoDumpPath
Posted by Peng Liang 4 years, 5 months ago
Signed-off-by: Peng Liang <liangpeng10@huawei.com>
---
 src/qemu/qemu_driver.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index dfc27572c461..e929e950e848 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -3431,7 +3431,7 @@ qemuDomainScreenshot(virDomainPtr dom,
         }
     }
 
-    tmp = g_strdup_printf("%s/qemu.screendump.XXXXXX", cfg->cacheDir);
+    tmp = g_strdup_printf("%s/qemu.screendump.XXXXXX", cfg->autoDumpPath);
 
     if ((tmp_fd = g_mkstemp_full(tmp, O_RDWR | O_CLOEXEC, S_IRUSR | S_IWUSR)) == -1) {
         virReportSystemError(errno, _("g_mkstemp(\"%s\") failed"), tmp);
@@ -10692,7 +10692,7 @@ qemuDomainMemoryPeek(virDomainPtr dom,
     if (virDomainObjCheckActive(vm) < 0)
         goto endjob;
 
-    tmp = g_strdup_printf("%s/qemu.mem.XXXXXX", cfg->cacheDir);
+    tmp = g_strdup_printf("%s/qemu.mem.XXXXXX", cfg->autoDumpPath);
 
     /* Create a temporary filename. */
     if ((fd = g_mkstemp_full(tmp, O_RDWR | O_CLOEXEC, S_IRUSR | S_IWUSR)) == -1) {
-- 
2.31.1


Re: [PATCH 1/2] qemu: move temp file of screenshot and memorypeek to autoDumpPath
Posted by Peter Krempa 4 years, 5 months ago
On Mon, Sep 13, 2021 at 10:10:58 +0800, Peng Liang wrote:

Please elaborate in the commit message why you are making this change.

> Signed-off-by: Peng Liang <liangpeng10@huawei.com>
> ---
>  src/qemu/qemu_driver.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)