[PATCH 0/5] qemu: add virtio-blk queue-size option

Hiroki Narukawa posted 5 patches 2 weeks, 1 day ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210909033448.7018-1-hnarukaw@yahoo-corp.jp
docs/formatdomain.rst                         |  4 +-
docs/schemas/domaincommon.rng                 |  5 +++
src/conf/domain_conf.c                        | 20 ++++++++++
src/conf/domain_conf.h                        |  1 +
src/qemu/qemu_capabilities.c                  |  2 +
src/qemu/qemu_capabilities.h                  |  1 +
src/qemu/qemu_command.c                       |  3 ++
src/qemu/qemu_validate.c                      |  7 ++++
.../caps_2.12.0.aarch64.xml                   |  1 +
.../caps_2.12.0.ppc64.xml                     |  1 +
.../caps_2.12.0.s390x.xml                     |  1 +
.../caps_2.12.0.x86_64.xml                    |  1 +
.../qemucapabilitiesdata/caps_3.0.0.ppc64.xml |  1 +
.../qemucapabilitiesdata/caps_3.0.0.s390x.xml |  1 +
.../caps_3.0.0.x86_64.xml                     |  1 +
.../qemucapabilitiesdata/caps_3.1.0.ppc64.xml |  1 +
.../caps_3.1.0.x86_64.xml                     |  1 +
.../caps_4.0.0.aarch64.xml                    |  1 +
.../qemucapabilitiesdata/caps_4.0.0.ppc64.xml |  1 +
.../caps_4.0.0.riscv32.xml                    |  1 +
.../caps_4.0.0.riscv64.xml                    |  1 +
.../qemucapabilitiesdata/caps_4.0.0.s390x.xml |  1 +
.../caps_4.0.0.x86_64.xml                     |  1 +
.../caps_4.1.0.x86_64.xml                     |  1 +
.../caps_4.2.0.aarch64.xml                    |  1 +
.../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |  1 +
.../qemucapabilitiesdata/caps_4.2.0.s390x.xml |  1 +
.../caps_4.2.0.x86_64.xml                     |  1 +
.../caps_5.0.0.aarch64.xml                    |  1 +
.../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |  1 +
.../caps_5.0.0.riscv64.xml                    |  1 +
.../caps_5.0.0.x86_64.xml                     |  1 +
.../caps_5.1.0.x86_64.xml                     |  1 +
.../caps_5.2.0.aarch64.xml                    |  1 +
.../qemucapabilitiesdata/caps_5.2.0.ppc64.xml |  1 +
.../caps_5.2.0.riscv64.xml                    |  1 +
.../qemucapabilitiesdata/caps_5.2.0.s390x.xml |  1 +
.../caps_5.2.0.x86_64.xml                     |  1 +
.../caps_6.0.0.aarch64.xml                    |  1 +
.../qemucapabilitiesdata/caps_6.0.0.s390x.xml |  1 +
.../caps_6.0.0.x86_64.xml                     |  1 +
.../caps_6.1.0.x86_64.xml                     |  1 +
.../disk-virtio-queue-size.args               | 35 +++++++++++++++++
.../disk-virtio-queue-size.x86_64-latest.args | 35 +++++++++++++++++
.../disk-virtio-queue-size.xml                | 38 +++++++++++++++++++
.../qemuxml2argvdata/disk-virtio-queues.args  | 20 ++++++----
.../disk-virtio-queues.x86_64-latest.args     | 35 +++++++++++++++++
tests/qemuxml2argvdata/disk-virtio-queues.xml |  5 ++-
tests/qemuxml2argvtest.c                      |  4 +-
.../disk-virtio-queue-size.x86_64-latest.xml  | 38 +++++++++++++++++++
.../disk-virtio-queue-size.xml                | 35 +++++++++++++++++
.../disk-virtio-queues.x86_64-latest.xml      |  1 +
tests/qemuxml2xmltest.c                       |  3 +-
53 files changed, 314 insertions(+), 12 deletions(-)
create mode 100644 tests/qemuxml2argvdata/disk-virtio-queue-size.args
create mode 100644 tests/qemuxml2argvdata/disk-virtio-queue-size.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/disk-virtio-queue-size.xml
create mode 100644 tests/qemuxml2argvdata/disk-virtio-queues.x86_64-latest.args
create mode 100644 tests/qemuxml2xmloutdata/disk-virtio-queue-size.x86_64-latest.xml
create mode 100644 tests/qemuxml2xmloutdata/disk-virtio-queue-size.xml
create mode 120000 tests/qemuxml2xmloutdata/disk-virtio-queues.x86_64-latest.xml

[PATCH 0/5] qemu: add virtio-blk queue-size option

Posted by Hiroki Narukawa 2 weeks, 1 day ago
This is resubmit of "qemu: add virtio-blk queue-size option" after following the review.

The option "queue-size" in virtio-blk was added in qemu-2.12.0, and default value increased from qemu-5.0.0.
However, increasing this value may lead to drop of random access performance.
This is configurable value, so we want to use it via libvirt.

Hiroki Narukawa (5):
  qemu: Make disk-virtio-queues tests use DO_TEST_CAPS_LATEST
  qemu: add disk queue count ABI stability check
  qemu: add queue_size option to disk
  qemu: add QEMU_CAPS_VIRTIO_BLK_QUEUE_SIZE capability
  qemu: add virtio-blk queue-size option

 docs/formatdomain.rst                         |  4 +-
 docs/schemas/domaincommon.rng                 |  5 +++
 src/conf/domain_conf.c                        | 20 ++++++++++
 src/conf/domain_conf.h                        |  1 +
 src/qemu/qemu_capabilities.c                  |  2 +
 src/qemu/qemu_capabilities.h                  |  1 +
 src/qemu/qemu_command.c                       |  3 ++
 src/qemu/qemu_validate.c                      |  7 ++++
 .../caps_2.12.0.aarch64.xml                   |  1 +
 .../caps_2.12.0.ppc64.xml                     |  1 +
 .../caps_2.12.0.s390x.xml                     |  1 +
 .../caps_2.12.0.x86_64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml |  1 +
 .../qemucapabilitiesdata/caps_3.0.0.s390x.xml |  1 +
 .../caps_3.0.0.x86_64.xml                     |  1 +
 .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml |  1 +
 .../caps_3.1.0.x86_64.xml                     |  1 +
 .../caps_4.0.0.aarch64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml |  1 +
 .../caps_4.0.0.riscv32.xml                    |  1 +
 .../caps_4.0.0.riscv64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_4.0.0.s390x.xml |  1 +
 .../caps_4.0.0.x86_64.xml                     |  1 +
 .../caps_4.1.0.x86_64.xml                     |  1 +
 .../caps_4.2.0.aarch64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |  1 +
 .../qemucapabilitiesdata/caps_4.2.0.s390x.xml |  1 +
 .../caps_4.2.0.x86_64.xml                     |  1 +
 .../caps_5.0.0.aarch64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |  1 +
 .../caps_5.0.0.riscv64.xml                    |  1 +
 .../caps_5.0.0.x86_64.xml                     |  1 +
 .../caps_5.1.0.x86_64.xml                     |  1 +
 .../caps_5.2.0.aarch64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml |  1 +
 .../caps_5.2.0.riscv64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_5.2.0.s390x.xml |  1 +
 .../caps_5.2.0.x86_64.xml                     |  1 +
 .../caps_6.0.0.aarch64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_6.0.0.s390x.xml |  1 +
 .../caps_6.0.0.x86_64.xml                     |  1 +
 .../caps_6.1.0.x86_64.xml                     |  1 +
 .../disk-virtio-queue-size.args               | 35 +++++++++++++++++
 .../disk-virtio-queue-size.x86_64-latest.args | 35 +++++++++++++++++
 .../disk-virtio-queue-size.xml                | 38 +++++++++++++++++++
 .../qemuxml2argvdata/disk-virtio-queues.args  | 20 ++++++----
 .../disk-virtio-queues.x86_64-latest.args     | 35 +++++++++++++++++
 tests/qemuxml2argvdata/disk-virtio-queues.xml |  5 ++-
 tests/qemuxml2argvtest.c                      |  4 +-
 .../disk-virtio-queue-size.x86_64-latest.xml  | 38 +++++++++++++++++++
 .../disk-virtio-queue-size.xml                | 35 +++++++++++++++++
 .../disk-virtio-queues.x86_64-latest.xml      |  1 +
 tests/qemuxml2xmltest.c                       |  3 +-
 53 files changed, 314 insertions(+), 12 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/disk-virtio-queue-size.args
 create mode 100644 tests/qemuxml2argvdata/disk-virtio-queue-size.x86_64-latest.args
 create mode 100644 tests/qemuxml2argvdata/disk-virtio-queue-size.xml
 create mode 100644 tests/qemuxml2argvdata/disk-virtio-queues.x86_64-latest.args
 create mode 100644 tests/qemuxml2xmloutdata/disk-virtio-queue-size.x86_64-latest.xml
 create mode 100644 tests/qemuxml2xmloutdata/disk-virtio-queue-size.xml
 create mode 120000 tests/qemuxml2xmloutdata/disk-virtio-queues.x86_64-latest.xml

-- 
2.17.1

RE: [PATCH 0/5] qemu: add virtio-blk queue-size option

Posted by Hiroki Narukawa 3 days, 22 hours ago
Hello,

Can I know how is the status of this patchset? In this patchset all reviews I received are applied, and this is ready for review.


-----Original Message-----
From: 成川 弘樹 <hnarukaw@yahoo-corp.jp> 
Sent: Thursday, September 9, 2021 12:35 PM
To: libvir-list@redhat.com
Cc: 大岩 朗 <aoiwa@yahoo-corp.jp>; 成川 弘樹 <hnarukaw@yahoo-corp.jp>
Subject: [PATCH 0/5] qemu: add virtio-blk queue-size option

This is resubmit of "qemu: add virtio-blk queue-size option" after following the review.

The option "queue-size" in virtio-blk was added in qemu-2.12.0, and default value increased from qemu-5.0.0.
However, increasing this value may lead to drop of random access performance.
This is configurable value, so we want to use it via libvirt.

Hiroki Narukawa (5):
  qemu: Make disk-virtio-queues tests use DO_TEST_CAPS_LATEST
  qemu: add disk queue count ABI stability check
  qemu: add queue_size option to disk
  qemu: add QEMU_CAPS_VIRTIO_BLK_QUEUE_SIZE capability
  qemu: add virtio-blk queue-size option

 docs/formatdomain.rst                         |  4 +-
 docs/schemas/domaincommon.rng                 |  5 +++
 src/conf/domain_conf.c                        | 20 ++++++++++
 src/conf/domain_conf.h                        |  1 +
 src/qemu/qemu_capabilities.c                  |  2 +
 src/qemu/qemu_capabilities.h                  |  1 +
 src/qemu/qemu_command.c                       |  3 ++
 src/qemu/qemu_validate.c                      |  7 ++++
 .../caps_2.12.0.aarch64.xml                   |  1 +
 .../caps_2.12.0.ppc64.xml                     |  1 +
 .../caps_2.12.0.s390x.xml                     |  1 +
 .../caps_2.12.0.x86_64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml |  1 +  .../qemucapabilitiesdata/caps_3.0.0.s390x.xml |  1 +
 .../caps_3.0.0.x86_64.xml                     |  1 +
 .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml |  1 +
 .../caps_3.1.0.x86_64.xml                     |  1 +
 .../caps_4.0.0.aarch64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml |  1 +
 .../caps_4.0.0.riscv32.xml                    |  1 +
 .../caps_4.0.0.riscv64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_4.0.0.s390x.xml |  1 +
 .../caps_4.0.0.x86_64.xml                     |  1 +
 .../caps_4.1.0.x86_64.xml                     |  1 +
 .../caps_4.2.0.aarch64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |  1 +  .../qemucapabilitiesdata/caps_4.2.0.s390x.xml |  1 +
 .../caps_4.2.0.x86_64.xml                     |  1 +
 .../caps_5.0.0.aarch64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |  1 +
 .../caps_5.0.0.riscv64.xml                    |  1 +
 .../caps_5.0.0.x86_64.xml                     |  1 +
 .../caps_5.1.0.x86_64.xml                     |  1 +
 .../caps_5.2.0.aarch64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml |  1 +
 .../caps_5.2.0.riscv64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_5.2.0.s390x.xml |  1 +
 .../caps_5.2.0.x86_64.xml                     |  1 +
 .../caps_6.0.0.aarch64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_6.0.0.s390x.xml |  1 +
 .../caps_6.0.0.x86_64.xml                     |  1 +
 .../caps_6.1.0.x86_64.xml                     |  1 +
 .../disk-virtio-queue-size.args               | 35 +++++++++++++++++
 .../disk-virtio-queue-size.x86_64-latest.args | 35 +++++++++++++++++
 .../disk-virtio-queue-size.xml                | 38 +++++++++++++++++++
 .../qemuxml2argvdata/disk-virtio-queues.args  | 20 ++++++----
 .../disk-virtio-queues.x86_64-latest.args     | 35 +++++++++++++++++
 tests/qemuxml2argvdata/disk-virtio-queues.xml |  5 ++-
 tests/qemuxml2argvtest.c                      |  4 +-
 .../disk-virtio-queue-size.x86_64-latest.xml  | 38 +++++++++++++++++++
 .../disk-virtio-queue-size.xml                | 35 +++++++++++++++++
 .../disk-virtio-queues.x86_64-latest.xml      |  1 +
 tests/qemuxml2xmltest.c                       |  3 +-
 53 files changed, 314 insertions(+), 12 deletions(-)  create mode 100644 tests/qemuxml2argvdata/disk-virtio-queue-size.args
 create mode 100644 tests/qemuxml2argvdata/disk-virtio-queue-size.x86_64-latest.args
 create mode 100644 tests/qemuxml2argvdata/disk-virtio-queue-size.xml
 create mode 100644 tests/qemuxml2argvdata/disk-virtio-queues.x86_64-latest.args
 create mode 100644 tests/qemuxml2xmloutdata/disk-virtio-queue-size.x86_64-latest.xml
 create mode 100644 tests/qemuxml2xmloutdata/disk-virtio-queue-size.xml
 create mode 120000 tests/qemuxml2xmloutdata/disk-virtio-queues.x86_64-latest.xml

--
2.17.1