virsh: Display vhostuser socket path in domblklist

[PATCH] virsh: Display vhostuser socket path in domblklist

dinglimin posted 1 patch 2 years, 7 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210903085453.1067-1-dinglimin@cmss.chinamobile.com

tools/virsh-domain-monitor.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH] virsh: Display vhostuser socket path in domblklist

Posted by dinglimin 2 years, 7 months ago

The domblklist command is designed to show a brief information about the blocks of a domain.
One piece of information that is shows is "Target "and "Source".
Before the modification, the Vhost disk of SPDK is displayed as "-".
After the modification, the socket associated with it can be displayed

Signed-off-by: dinglimin <dinglimin@cmss.chinamobile.com>
---
 tools/virsh-domain-monitor.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c
index f7cf82acdf..eb3e0ef11a 100644
--- a/tools/virsh-domain-monitor.c
+++ b/tools/virsh-domain-monitor.c
@@ -644,7 +644,8 @@ cmdDomblklist(vshControl *ctl, const vshCmd *cmd)
                                     "|./source/@dev"
                                     "|./source/@dir"
                                     "|./source/@name"
-                                    "|./source/@volume)", ctxt);
+                                    "|./source/@volume"
+                                    "|./source/@path)", ctxt);
         }
 
         if (details) {
-- 
2.18.2

Re: [PATCH] virsh: Display vhostuser socket path in domblklist

Posted by Michal Prívozník 2 years, 7 months ago

On 9/3/21 10:54 AM, dinglimin wrote:
> The domblklist command is designed to show a brief information about the blocks of a domain.
> One piece of information that is shows is "Target "and "Source".
> Before the modification, the Vhost disk of SPDK is displayed as "-".
> After the modification, the socket associated with it can be displayed
> 
> Signed-off-by: dinglimin <dinglimin@cmss.chinamobile.com>
> ---
>  tools/virsh-domain-monitor.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c
> index f7cf82acdf..eb3e0ef11a 100644
> --- a/tools/virsh-domain-monitor.c
> +++ b/tools/virsh-domain-monitor.c
> @@ -644,7 +644,8 @@ cmdDomblklist(vshControl *ctl, const vshCmd *cmd)
>                                      "|./source/@dev"
>                                      "|./source/@dir"
>                                      "|./source/@name"
> -                                    "|./source/@volume)", ctxt);
> +                                    "|./source/@volume"
> +                                    "|./source/@path)", ctxt);
>          }
>  
>          if (details) {
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and pushed. Congratulations on your first libvirt contribution!

Michal