[v2] Support VM core dump to block device

[PATCHv2 0/2] Support VM core dump to block device

Simon Rowe posted 2 patches 2 years, 8 months ago

Diff against v1
Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210823154048.94655-1-simon.rowe@nutanix.com

src/qemu/qemu_driver.c |  8 +++-----
src/util/iohelper.c    | 10 ++++++++--
2 files changed, 11 insertions(+), 7 deletions(-)

Expand all Fold all

[PATCHv2 0/2] Support VM core dump to block device

Posted by Simon Rowe 2 years, 8 months ago

When the destination of a VM core dump is a block device (e.g. NBD)
avoid file operations that are unnecessary.

Simon Rowe (2):
  iohelper: skip lseek() and ftruncate() on block devices
  qemu: check unlink hint from virQEMUFileOpenAs()

 src/qemu/qemu_driver.c |  8 +++-----
 src/util/iohelper.c    | 10 ++++++++--
 2 files changed, 11 insertions(+), 7 deletions(-)

-- 
2.22.3

Re: [PATCHv2 0/2] Support VM core dump to block device

Posted by Michal Prívozník 2 years, 8 months ago

On 8/23/21 5:40 PM, Simon Rowe wrote:
> When the destination of a VM core dump is a block device (e.g. NBD)
> avoid file operations that are unnecessary.
> 
> Simon Rowe (2):
>   iohelper: skip lseek() and ftruncate() on block devices
>   qemu: check unlink hint from virQEMUFileOpenAs()
> 
>  src/qemu/qemu_driver.c |  8 +++-----
>  src/util/iohelper.c    | 10 ++++++++--
>  2 files changed, 11 insertions(+), 7 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

Re: [PATCHv2 0/2] Support VM core dump to block device

Posted by Michal Prívozník 2 years, 8 months ago

On 8/23/21 5:40 PM, Simon Rowe wrote:
> When the destination of a VM core dump is a block device (e.g. NBD)
> avoid file operations that are unnecessary.
> 
> Simon Rowe (2):
>   iohelper: skip lseek() and ftruncate() on block devices
>   qemu: check unlink hint from virQEMUFileOpenAs()
> 
>  src/qemu/qemu_driver.c |  8 +++-----
>  src/util/iohelper.c    | 10 ++++++++--
>  2 files changed, 11 insertions(+), 7 deletions(-)
> 

Sqaushed in suggested diff and pushed. Congratulations on your first
libvirt contribution!

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal