[libvirt PATCH 0/2] meson: Detect and reject invalid rst2html5 command

Andrea Bolognani posted 2 patches 2 years, 8 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210809151329.73017-1-abologna@redhat.com
docs/go/meson.build       |  2 +-
docs/kbase/meson.build    |  2 +-
docs/manpages/meson.build |  2 +-
docs/meson.build          |  8 ++++----
meson.build               | 30 +++++++++++++++++++++++++++++-
5 files changed, 36 insertions(+), 8 deletions(-)
[libvirt PATCH 0/2] meson: Detect and reject invalid rst2html5 command
Posted by Andrea Bolognani 2 years, 8 months ago
Previous attempt at solving this issue:

  https://listman.redhat.com/archives/libvir-list/2021-June/msg00097.html

The solution presented here should be way more future-proof, though
there's of course always the risk that the format used to report
version information will change in a way that causes our detection to
trip over...

Andrea Bolognani (2):
  meson: Use 'rst2html5' instead of 'rst2html' everywhere
  meson: Detect and reject invalid rst2html5 command

 docs/go/meson.build       |  2 +-
 docs/kbase/meson.build    |  2 +-
 docs/manpages/meson.build |  2 +-
 docs/meson.build          |  8 ++++----
 meson.build               | 30 +++++++++++++++++++++++++++++-
 5 files changed, 36 insertions(+), 8 deletions(-)

-- 
2.31.1


Re: [libvirt PATCH 0/2] meson: Detect and reject invalid rst2html5 command
Posted by Pavel Hrdina 2 years, 8 months ago
On Mon, Aug 09, 2021 at 05:13:27PM +0200, Andrea Bolognani wrote:
> Previous attempt at solving this issue:
> 
>   https://listman.redhat.com/archives/libvir-list/2021-June/msg00097.html
> 
> The solution presented here should be way more future-proof, though
> there's of course always the risk that the format used to report
> version information will change in a way that causes our detection to
> trip over...

This definitely improves the situation, let's hope they will not change
the --version output to have it the same :).

> Andrea Bolognani (2):
>   meson: Use 'rst2html5' instead of 'rst2html' everywhere
>   meson: Detect and reject invalid rst2html5 command

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>