[PATCH v3 0/3] remove sysconfig files

Olaf Hering posted 3 patches 2 years, 8 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210802111859.16137-1-olaf@aepfle.de
There is a newer version of this series
NEWS.rst                                |  10 +++
docs/daemons.rst                        |  20 +++++
docs/remote.html.in                     |   2 +-
libvirt.spec.in                         | 100 ++++++++++++++++--------
src/ch/meson.build                      |   5 --
src/ch/virtchd.service.in               |   1 +
src/ch/virtchd.sysconf                  |   3 -
src/interface/meson.build               |   5 --
src/interface/virtinterfaced.service.in |   1 +
src/interface/virtinterfaced.sysconf    |   3 -
src/libxl/meson.build                   |   5 --
src/libxl/virtxend.service.in           |   1 +
src/libxl/virtxend.sysconf              |   3 -
src/locking/meson.build                 |   5 --
src/locking/virtlockd.service.in        |   1 +
src/locking/virtlockd.sysconf           |   3 -
src/logging/meson.build                 |   5 --
src/logging/virtlogd.sysconf            |   3 -
src/lxc/meson.build                     |   5 --
src/lxc/virtlxcd.service.in             |   1 +
src/lxc/virtlxcd.sysconf                |   3 -
src/meson.build                         |  16 ----
src/network/meson.build                 |   5 --
src/network/virtnetworkd.service.in     |   1 +
src/network/virtnetworkd.sysconf        |   3 -
src/node_device/meson.build             |   5 --
src/node_device/virtnodedevd.service.in |   1 +
src/node_device/virtnodedevd.sysconf    |   3 -
src/nwfilter/meson.build                |   5 --
src/nwfilter/virtnwfilterd.service.in   |   1 +
src/nwfilter/virtnwfilterd.sysconf      |   3 -
src/qemu/meson.build                    |   5 --
src/qemu/virtqemud.service.in           |   7 ++
src/qemu/virtqemud.sysconf              |  12 ---
src/remote/libvirtd.service.in          |   7 ++
src/remote/libvirtd.sysconf             |  21 -----
src/remote/meson.build                  |  10 ---
src/remote/virtproxyd.service.in        |   1 +
src/remote/virtproxyd.sysconf           |   3 -
src/secret/meson.build                  |   5 --
src/secret/virtsecretd.service.in       |   1 +
src/secret/virtsecretd.sysconf          |   3 -
src/storage/meson.build                 |   5 --
src/storage/virtstoraged.service.in     |   1 +
src/storage/virtstoraged.sysconf        |   3 -
src/vbox/meson.build                    |   5 --
src/vbox/virtvboxd.service.in           |   1 +
src/vbox/virtvboxd.sysconf              |   3 -
src/vz/meson.build                      |   5 --
src/vz/virtvzd.service.in               |   1 +
src/vz/virtvzd.sysconf                  |   3 -
tools/libvirt-guests.sh.in              |  40 ++++++++++
tools/libvirt-guests.sysconf            |  50 ------------
tools/meson.build                       |   6 --
54 files changed, 166 insertions(+), 260 deletions(-)
delete mode 100644 src/ch/virtchd.sysconf
delete mode 100644 src/interface/virtinterfaced.sysconf
delete mode 100644 src/libxl/virtxend.sysconf
delete mode 100644 src/locking/virtlockd.sysconf
delete mode 100644 src/logging/virtlogd.sysconf
delete mode 100644 src/lxc/virtlxcd.sysconf
delete mode 100644 src/network/virtnetworkd.sysconf
delete mode 100644 src/node_device/virtnodedevd.sysconf
delete mode 100644 src/nwfilter/virtnwfilterd.sysconf
delete mode 100644 src/qemu/virtqemud.sysconf
delete mode 100644 src/remote/libvirtd.sysconf
delete mode 100644 src/remote/virtproxyd.sysconf
delete mode 100644 src/secret/virtsecretd.sysconf
delete mode 100644 src/storage/virtstoraged.sysconf
delete mode 100644 src/vbox/virtvboxd.sysconf
delete mode 100644 src/vz/virtvzd.sysconf
delete mode 100644 tools/libvirt-guests.sysconf
[PATCH v3 0/3] remove sysconfig files
Posted by Olaf Hering 2 years, 8 months ago
rebased to 919f25d36ef0ea41c50bdb5afa0b83187ffb3c87

Olaf Hering (3):
  libvirt.spec: relocate pre script of daemon-driver-qemu
  remove sysconfig files
  NEWS: mention removal of sysconfig

 NEWS.rst                                |  10 +++
 docs/daemons.rst                        |  20 +++++
 docs/remote.html.in                     |   2 +-
 libvirt.spec.in                         | 100 ++++++++++++++++--------
 src/ch/meson.build                      |   5 --
 src/ch/virtchd.service.in               |   1 +
 src/ch/virtchd.sysconf                  |   3 -
 src/interface/meson.build               |   5 --
 src/interface/virtinterfaced.service.in |   1 +
 src/interface/virtinterfaced.sysconf    |   3 -
 src/libxl/meson.build                   |   5 --
 src/libxl/virtxend.service.in           |   1 +
 src/libxl/virtxend.sysconf              |   3 -
 src/locking/meson.build                 |   5 --
 src/locking/virtlockd.service.in        |   1 +
 src/locking/virtlockd.sysconf           |   3 -
 src/logging/meson.build                 |   5 --
 src/logging/virtlogd.sysconf            |   3 -
 src/lxc/meson.build                     |   5 --
 src/lxc/virtlxcd.service.in             |   1 +
 src/lxc/virtlxcd.sysconf                |   3 -
 src/meson.build                         |  16 ----
 src/network/meson.build                 |   5 --
 src/network/virtnetworkd.service.in     |   1 +
 src/network/virtnetworkd.sysconf        |   3 -
 src/node_device/meson.build             |   5 --
 src/node_device/virtnodedevd.service.in |   1 +
 src/node_device/virtnodedevd.sysconf    |   3 -
 src/nwfilter/meson.build                |   5 --
 src/nwfilter/virtnwfilterd.service.in   |   1 +
 src/nwfilter/virtnwfilterd.sysconf      |   3 -
 src/qemu/meson.build                    |   5 --
 src/qemu/virtqemud.service.in           |   7 ++
 src/qemu/virtqemud.sysconf              |  12 ---
 src/remote/libvirtd.service.in          |   7 ++
 src/remote/libvirtd.sysconf             |  21 -----
 src/remote/meson.build                  |  10 ---
 src/remote/virtproxyd.service.in        |   1 +
 src/remote/virtproxyd.sysconf           |   3 -
 src/secret/meson.build                  |   5 --
 src/secret/virtsecretd.service.in       |   1 +
 src/secret/virtsecretd.sysconf          |   3 -
 src/storage/meson.build                 |   5 --
 src/storage/virtstoraged.service.in     |   1 +
 src/storage/virtstoraged.sysconf        |   3 -
 src/vbox/meson.build                    |   5 --
 src/vbox/virtvboxd.service.in           |   1 +
 src/vbox/virtvboxd.sysconf              |   3 -
 src/vz/meson.build                      |   5 --
 src/vz/virtvzd.service.in               |   1 +
 src/vz/virtvzd.sysconf                  |   3 -
 tools/libvirt-guests.sh.in              |  40 ++++++++++
 tools/libvirt-guests.sysconf            |  50 ------------
 tools/meson.build                       |   6 --
 54 files changed, 166 insertions(+), 260 deletions(-)
 delete mode 100644 src/ch/virtchd.sysconf
 delete mode 100644 src/interface/virtinterfaced.sysconf
 delete mode 100644 src/libxl/virtxend.sysconf
 delete mode 100644 src/locking/virtlockd.sysconf
 delete mode 100644 src/logging/virtlogd.sysconf
 delete mode 100644 src/lxc/virtlxcd.sysconf
 delete mode 100644 src/network/virtnetworkd.sysconf
 delete mode 100644 src/node_device/virtnodedevd.sysconf
 delete mode 100644 src/nwfilter/virtnwfilterd.sysconf
 delete mode 100644 src/qemu/virtqemud.sysconf
 delete mode 100644 src/remote/libvirtd.sysconf
 delete mode 100644 src/remote/virtproxyd.sysconf
 delete mode 100644 src/secret/virtsecretd.sysconf
 delete mode 100644 src/storage/virtstoraged.sysconf
 delete mode 100644 src/vbox/virtvboxd.sysconf
 delete mode 100644 src/vz/virtvzd.sysconf
 delete mode 100644 tools/libvirt-guests.sysconf

Re: [PATCH v3 0/3] remove sysconfig files
Posted by Jim Fehlig 2 years, 6 months ago
Hi All!

I'd like to revive discussion on this series. It LGTM with the exception of a 
few small nits in 2/3. AFAICT, all concerns were addressed. Are there any 
objections to removing these files? Have all distro maintainers spoken their peace?

If there are no objections, it would be nice to get this pushed early in the dev 
cycle, after the release of 7.8.0.

On 8/2/21 05:18, Olaf Hering wrote:
> rebased to 919f25d36ef0ea41c50bdb5afa0b83187ffb3c87

Needs rebased again :-).

Regards,
Jim

> 
> Olaf Hering (3):
>    libvirt.spec: relocate pre script of daemon-driver-qemu
>    remove sysconfig files
>    NEWS: mention removal of sysconfig
> 
>   NEWS.rst                                |  10 +++
>   docs/daemons.rst                        |  20 +++++
>   docs/remote.html.in                     |   2 +-
>   libvirt.spec.in                         | 100 ++++++++++++++++--------
>   src/ch/meson.build                      |   5 --
>   src/ch/virtchd.service.in               |   1 +
>   src/ch/virtchd.sysconf                  |   3 -
>   src/interface/meson.build               |   5 --
>   src/interface/virtinterfaced.service.in |   1 +
>   src/interface/virtinterfaced.sysconf    |   3 -
>   src/libxl/meson.build                   |   5 --
>   src/libxl/virtxend.service.in           |   1 +
>   src/libxl/virtxend.sysconf              |   3 -
>   src/locking/meson.build                 |   5 --
>   src/locking/virtlockd.service.in        |   1 +
>   src/locking/virtlockd.sysconf           |   3 -
>   src/logging/meson.build                 |   5 --
>   src/logging/virtlogd.sysconf            |   3 -
>   src/lxc/meson.build                     |   5 --
>   src/lxc/virtlxcd.service.in             |   1 +
>   src/lxc/virtlxcd.sysconf                |   3 -
>   src/meson.build                         |  16 ----
>   src/network/meson.build                 |   5 --
>   src/network/virtnetworkd.service.in     |   1 +
>   src/network/virtnetworkd.sysconf        |   3 -
>   src/node_device/meson.build             |   5 --
>   src/node_device/virtnodedevd.service.in |   1 +
>   src/node_device/virtnodedevd.sysconf    |   3 -
>   src/nwfilter/meson.build                |   5 --
>   src/nwfilter/virtnwfilterd.service.in   |   1 +
>   src/nwfilter/virtnwfilterd.sysconf      |   3 -
>   src/qemu/meson.build                    |   5 --
>   src/qemu/virtqemud.service.in           |   7 ++
>   src/qemu/virtqemud.sysconf              |  12 ---
>   src/remote/libvirtd.service.in          |   7 ++
>   src/remote/libvirtd.sysconf             |  21 -----
>   src/remote/meson.build                  |  10 ---
>   src/remote/virtproxyd.service.in        |   1 +
>   src/remote/virtproxyd.sysconf           |   3 -
>   src/secret/meson.build                  |   5 --
>   src/secret/virtsecretd.service.in       |   1 +
>   src/secret/virtsecretd.sysconf          |   3 -
>   src/storage/meson.build                 |   5 --
>   src/storage/virtstoraged.service.in     |   1 +
>   src/storage/virtstoraged.sysconf        |   3 -
>   src/vbox/meson.build                    |   5 --
>   src/vbox/virtvboxd.service.in           |   1 +
>   src/vbox/virtvboxd.sysconf              |   3 -
>   src/vz/meson.build                      |   5 --
>   src/vz/virtvzd.service.in               |   1 +
>   src/vz/virtvzd.sysconf                  |   3 -
>   tools/libvirt-guests.sh.in              |  40 ++++++++++
>   tools/libvirt-guests.sysconf            |  50 ------------
>   tools/meson.build                       |   6 --
>   54 files changed, 166 insertions(+), 260 deletions(-)
>   delete mode 100644 src/ch/virtchd.sysconf
>   delete mode 100644 src/interface/virtinterfaced.sysconf
>   delete mode 100644 src/libxl/virtxend.sysconf
>   delete mode 100644 src/locking/virtlockd.sysconf
>   delete mode 100644 src/logging/virtlogd.sysconf
>   delete mode 100644 src/lxc/virtlxcd.sysconf
>   delete mode 100644 src/network/virtnetworkd.sysconf
>   delete mode 100644 src/node_device/virtnodedevd.sysconf
>   delete mode 100644 src/nwfilter/virtnwfilterd.sysconf
>   delete mode 100644 src/qemu/virtqemud.sysconf
>   delete mode 100644 src/remote/libvirtd.sysconf
>   delete mode 100644 src/remote/virtproxyd.sysconf
>   delete mode 100644 src/secret/virtsecretd.sysconf
>   delete mode 100644 src/storage/virtstoraged.sysconf
>   delete mode 100644 src/vbox/virtvboxd.sysconf
>   delete mode 100644 src/vz/virtvzd.sysconf
>   delete mode 100644 tools/libvirt-guests.sysconf
> 

Re: [PATCH v3 0/3] remove sysconfig files
Posted by Olaf Hering 2 years, 6 months ago
Am Fri, 24 Sep 2021 08:49:55 -0600
schrieb Jim Fehlig <jfehlig@suse.com>:

> Needs rebased again :-).

Sadly, yes...

Olaf