rpm: properly disble -Werror

[PATCH] rpm: properly disble -Werror

Posted by Daniel P. Berrangé 2 years, 9 months ago

Since we use git to manage RPM applied patches, we need to disable both
meson's -Werror config knob and libvirt's equivalent.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 libvirt.spec.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index cb48dd0be0..b09336b441 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -192,7 +192,7 @@
 %if 0%{?rhel}
     %define enable_werror -Dwerror=true
 %else
-    %define enable_werror -Dwerror=false
+    %define enable_werror -Dwerror=false -Wgit_werror=disabled
 %endif
 
 %define tls_priority "@LIBVIRT,SYSTEM"
-- 
2.31.1

Re: [PATCH] rpm: properly disble -Werror

Posted by Michal Prívozník 2 years, 9 months ago

On 7/28/21 4:14 PM, Daniel P. Berrangé wrote:
> Since we use git to manage RPM applied patches, we need to disable both
> meson's -Werror config knob and libvirt's equivalent.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  libvirt.spec.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index cb48dd0be0..b09336b441 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -192,7 +192,7 @@
>  %if 0%{?rhel}
>      %define enable_werror -Dwerror=true
>  %else
> -    %define enable_werror -Dwerror=false
> +    %define enable_werror -Dwerror=false -Wgit_werror=disabled

I think you meant -Dgit_werror=disabled.

>  %endif
>  
>  %define tls_priority "@LIBVIRT,SYSTEM"
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

Re: [PATCH] rpm: properly disble -Werror

Posted by Jano Tomko 2 years, 9 months ago

On a %A in %Y, Daniel P. Berrangé wrote:
> Since we use git to manage RPM applied patches, we need to disable both
> meson's -Werror config knob and libvirt's equivalent.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  libvirt.spec.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index cb48dd0be0..b09336b441 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -192,7 +192,7 @@
>  %if 0%{?rhel}
>      %define enable_werror -Dwerror=true
>  %else
> -    %define enable_werror -Dwerror=false
> +    %define enable_werror -Dwerror=false -Wgit_werror=disabled
>  %endif
>  
>  %define tls_priority "@LIBVIRT,SYSTEM"
> 

s/disble/disable/ in the commit summary

Jano