gitlab: let rawhide container builds fail

[PATCH] gitlab: let rawhide container builds fail

Posted by Daniel P. Berrangé 2 years, 9 months ago

The nature of Fedora rawhide means that it will inevitably have failures
periodically. Currently it is failing to even update packages due to
glibc switching to use of clone3 syscall, which is mistakenly blocked by
seccomp in container runtimes using EPERM instead of ENOSYS.

When we fail to build the rawhide containers, it is quite likely that we
still have the previous build available in the gitlab registry, so it is
reasonable to allow the container job to fail and try the build job
anyway.

Ideally we would ignore the container build failure if-and-only-if the
previous container was build with the same list of packages. We don't
record the original dependency package list though, so that's not
currently possible.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 .gitlab-ci.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 4757139fa9..344ecdf3ba 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -186,7 +186,7 @@ x64-fedora-34-container:
     NAME: fedora-34
 
 x64-fedora-rawhide-container:
-  extends: .container_job
+  extends: .container_optional_job
   variables:
     NAME: fedora-rawhide
 
@@ -299,12 +299,12 @@ s390x-debian-sid-container:
     NAME: debian-sid-cross-s390x
 
 mingw32-fedora-rawhide-container:
-  extends: .container_job
+  extends: .container_optional_job
   variables:
     NAME: fedora-rawhide-cross-mingw32
 
 mingw64-fedora-rawhide-container:
-  extends: .container_job
+  extends: .container_optional_job
   variables:
     NAME: fedora-rawhide-cross-mingw64
 
-- 
2.31.1

Re: [PATCH] gitlab: let rawhide container builds fail

Posted by Peter Krempa 2 years, 9 months ago

On Mon, Jul 26, 2021 at 10:55:45 +0100, Daniel P. Berrangé wrote:
> The nature of Fedora rawhide means that it will inevitably have failures
> periodically. Currently it is failing to even update packages due to
> glibc switching to use of clone3 syscall, which is mistakenly blocked by
> seccomp in container runtimes using EPERM instead of ENOSYS.
> 
> When we fail to build the rawhide containers, it is quite likely that we
> still have the previous build available in the gitlab registry, so it is
> reasonable to allow the container job to fail and try the build job
> anyway.
> 
> Ideally we would ignore the container build failure if-and-only-if the
> previous container was build with the same list of packages. We don't
> record the original dependency package list though, so that's not
> currently possible.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  .gitlab-ci.yml | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>