virHashNew refactorings - part V

[libvirt PATCH 00/10] virHashNew refactorings - part V

Posted by Tim Wiederhake 2 years, 9 months ago

"virHashNew" cannot return NULL, yet we check for NULL in various places.

See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html.

Tim Wiederhake (10):
  conf: Add AUTOPTR_CLEANUP_FUNC for virNWFilterVarValue
  virNWFilterParseParamAttributes: `virHashNew` cannot return NULL
  virNWFilterParseParamAttributes: Iterate over "element" children
  virNWFilterParseParamAttributes: Remove tautological `if`
  virNWFilterParseParamAttributes: Use automatic memory management
  virNWFilterParseParamAttributes: Simplify loop body
  virNWFilterParseParamAttributes: Remove superfluous `goto`s
  virNWFilterDoInstantiate: `virHashNew` cannot return NULL
  virNWFilterIPAddrMapInit: `virHashNew` cannot return NULL
  virNWFilterLearnInit: `virHashNew` cannot return NULL

 src/conf/nwfilter_ipaddrmap.c          |  3 --
 src/conf/nwfilter_params.c             | 70 +++++++++-----------------
 src/conf/nwfilter_params.h             |  2 +
 src/nwfilter/nwfilter_gentech_driver.c |  5 --
 src/nwfilter/nwfilter_learnipaddr.c    |  8 ---
 5 files changed, 26 insertions(+), 62 deletions(-)

-- 
2.31.1

Re: [libvirt PATCH 00/10] virHashNew refactorings - part V

Posted by Jano Tomko 2 years, 9 months ago

On a %A in %Y, Tim Wiederhake wrote:
> "virHashNew" cannot return NULL, yet we check for NULL in various places.
> 
> See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html.
> 
> Tim Wiederhake (10):
>   conf: Add AUTOPTR_CLEANUP_FUNC for virNWFilterVarValue
>   virNWFilterParseParamAttributes: `virHashNew` cannot return NULL
>   virNWFilterParseParamAttributes: Iterate over "element" children
>   virNWFilterParseParamAttributes: Remove tautological `if`
>   virNWFilterParseParamAttributes: Use automatic memory management
>   virNWFilterParseParamAttributes: Simplify loop body
>   virNWFilterParseParamAttributes: Remove superfluous `goto`s
>   virNWFilterDoInstantiate: `virHashNew` cannot return NULL
>   virNWFilterIPAddrMapInit: `virHashNew` cannot return NULL
>   virNWFilterLearnInit: `virHashNew` cannot return NULL
> 
>  src/conf/nwfilter_ipaddrmap.c          |  3 --
>  src/conf/nwfilter_params.c             | 70 +++++++++-----------------
>  src/conf/nwfilter_params.h             |  2 +
>  src/nwfilter/nwfilter_gentech_driver.c |  5 --
>  src/nwfilter/nwfilter_learnipaddr.c    |  8 ---
>  5 files changed, 26 insertions(+), 62 deletions(-)
> 

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano

Re: [libvirt PATCH 00/10] virHashNew refactorings - part V

Posted by Tim Wiederhake 2 years, 9 months ago

ping

On Wed, 2021-07-14 at 11:44 +0200, Tim Wiederhake wrote:
> "virHashNew" cannot return NULL, yet we check for NULL in various
> places.
> 
> See
> https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html
> .
> 
> Tim Wiederhake (10):
>   conf: Add AUTOPTR_CLEANUP_FUNC for virNWFilterVarValue
>   virNWFilterParseParamAttributes: `virHashNew` cannot return NULL
>   virNWFilterParseParamAttributes: Iterate over "element" children
>   virNWFilterParseParamAttributes: Remove tautological `if`
>   virNWFilterParseParamAttributes: Use automatic memory management
>   virNWFilterParseParamAttributes: Simplify loop body
>   virNWFilterParseParamAttributes: Remove superfluous `goto`s
>   virNWFilterDoInstantiate: `virHashNew` cannot return NULL
>   virNWFilterIPAddrMapInit: `virHashNew` cannot return NULL
>   virNWFilterLearnInit: `virHashNew` cannot return NULL
> 
>  src/conf/nwfilter_ipaddrmap.c          |  3 --
>  src/conf/nwfilter_params.c             | 70 +++++++++---------------
> --
>  src/conf/nwfilter_params.h             |  2 +
>  src/nwfilter/nwfilter_gentech_driver.c |  5 --
>  src/nwfilter/nwfilter_learnipaddr.c    |  8 ---
>  5 files changed, 26 insertions(+), 62 deletions(-)
> 
> -- 
> 2.31.1
> 
>