[libvirt PATCH v2 00/10] virHashNew refactorings - part II

Tim Wiederhake posted 10 patches 2 years, 9 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20210713151212.62582-1-twiederh@redhat.com
src/qemu/qemu_monitor.c          | 10 +++-------
src/util/viriptables.c           | 20 +++++---------------
tests/nwfilterxml2firewalltest.c | 18 ++++++------------
3 files changed, 14 insertions(+), 34 deletions(-)
[libvirt PATCH v2 00/10] virHashNew refactorings - part II
Posted by Tim Wiederhake 2 years, 9 months ago
"virHashNew" cannot return NULL, yet we check for NULL in various places.

V1: https://listman.redhat.com/archives/libvir-list/2021-July/msg00188.html

Changes since V1:
* Moved the inversion of the `if` condition in patch #9 to patch #8
* Only patches #8 and #9 are missing review

Tim Wiederhake (10):
  virNWFilterCreateVarsFrom: `virHashNew` cannot return NULL
  virNWFilterCreateVarsFrom: Use automatic memory management
  virNWFilterCreateVarsFrom: Remove superfluous `goto`s
  virNWFilterRuleDefToRuleInst: `virHashNew` cannot return NULL
  iptablesPrivateChainCreate: `virHashNew` cannot return NULL
  iptablesPrivateChainCreate: Use automatic memory management
  iptablesPrivateChainCreate: Remove superfluous `goto`s
  qemuMonitorGetMemoryDeviceInfo: Assign hash table only on success
  qemuMonitorGetMemoryDeviceInfo: Use automatic memory management
  qemuMonitorGetMemoryDeviceInfo: `virHashNew` cannot return NULL

 src/qemu/qemu_monitor.c          | 10 +++-------
 src/util/viriptables.c           | 20 +++++---------------
 tests/nwfilterxml2firewalltest.c | 18 ++++++------------
 3 files changed, 14 insertions(+), 34 deletions(-)

-- 
2.31.1